From 3adef1780c2c5fd8f31a2a205a332d225c7afd94 Mon Sep 17 00:00:00 2001 From: Kristen Tian Date: Tue, 18 Oct 2022 18:16:10 -0700 Subject: [PATCH] [MD] Address UX comments - Update data source column header in index pattern table - Update index pattern column name to Title - Remove data source search field error check given it is not required Signed-off-by: Kristen Tian --- CHANGELOG.md | 1 + .../public/components/data_source_column/data_source_column.tsx | 2 +- .../components/header/__snapshots__/header.test.tsx.snap | 1 - .../components/step_data_source/components/header/header.tsx | 1 - .../components/index_pattern_table/index_pattern_table.tsx | 2 +- 5 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 90944d0b6438..8ebdc90cc572 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * [Multi DataSource] Make text content dynamically translated & update unit tests ([#2570](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2570)) * [Vis Builder] Change classname prefix wiz to vb ([#2581](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2581/files)) * [Vis Builder] Change wizard to vis_builder in file names and paths ([#2587](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2587)) +* [Multi DataSource] Address UX comments on index pattern management stack ([#2611](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2611)) ### 🐛 Bug Fixes * [Vis Builder] Fixes auto bounds for timeseries bar chart visualization ([2401](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2401)) diff --git a/src/plugins/data_source_management/public/components/data_source_column/data_source_column.tsx b/src/plugins/data_source_management/public/components/data_source_column/data_source_column.tsx index 6ac2258b7811..640eb1b369fd 100644 --- a/src/plugins/data_source_management/public/components/data_source_column/data_source_column.tsx +++ b/src/plugins/data_source_management/public/components/data_source_column/data_source_column.tsx @@ -24,7 +24,7 @@ export class DataSourceColumn implements IndexPatternTableColumn public euiColumn = { field: 'referenceId', name: i18n.translate('dataSource.management.dataSourceColumn', { - defaultMessage: 'Data Source', + defaultMessage: 'Data Source Connection', }), render: (referenceId: string, index: IndexPatternTableRecord) => { if (!referenceId) { diff --git a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap index e2e49b95177c..0fc55d1f52c7 100644 --- a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap +++ b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap @@ -74,7 +74,6 @@ exports[`Header should render existing data sources list when choose to use data searchProps={ Object { "data-test-subj": "selectDataSources", - "isInvalid": true, "placeholder": "Search data sources", } } diff --git a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx index d7af93be8f5b..601b03085222 100644 --- a/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx +++ b/src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx @@ -160,7 +160,6 @@ export const Header: React.FC = (props: HeaderProps) => { defaultMessage: 'Search data sources', } ), - isInvalid: !!dataSources, }} singleSelection={'always'} options={dataSources} diff --git a/src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx b/src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx index 8993d64750ef..f782d5ad1c18 100644 --- a/src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx +++ b/src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx @@ -183,7 +183,7 @@ export const IndexPatternTable = ({ canSave, history }: Props) => { const columns = [ { field: 'title', - name: 'Pattern', + name: 'Title', render: ( name: string, index: {