Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to install plugin on platform that is NOT LINUX #2026

Closed
seraphjiang opened this issue Jul 31, 2022 · 8 comments · Fixed by #2601
Closed

[BUG] Unable to install plugin on platform that is NOT LINUX #2026

seraphjiang opened this issue Jul 31, 2022 · 8 comments · Fixed by #2601
Labels
enhancement New feature or request

Comments

@seraphjiang
Copy link
Member

Describe the bug

Try to install plugin on my Mac environment, but got error

huanji@ea-osd % node scripts/opensearch_dashboards_plugin.js install kibana-ga-v0.1.0.tar.gz                                                                      
Plugins are only available for Linux

Expected behavior
Be able to install plugin on non-linux OS, MacOS, Windows

Dashboards Version
2.x

Plugins
https://github.com/jmcarp/kibana-ga

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: MacOS
@seraphjiang seraphjiang added bug Something isn't working untriaged labels Jul 31, 2022
@joshuarrrr
Copy link
Member

This is a feature request, not a bug - that appears to be the intended behavior of the script as per https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1316/files

@joshuarrrr joshuarrrr added enhancement New feature or request and removed bug Something isn't working untriaged labels Aug 1, 2022
@seraphjiang
Copy link
Member Author

Thanks @joshuarrrr
Could we know what's the motivation to introduce the constrains in #1316

@joshuarrrr
Copy link
Member

I don't have enough context there, but @kavilla may have more info.

@peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon changed the title [BUG] Unable to install plugin on MacOS [BUG] Unable to install plugin on platform that is NOT LINUX. Oct 12, 2022
@peterzhuamazon peterzhuamazon changed the title [BUG] Unable to install plugin on platform that is NOT LINUX. [BUG] Unable to install plugin on platform that is NOT LINUX Oct 12, 2022
@seraphjiang
Copy link
Member Author

This is a hard blocker for windows as well.
https://github.com/kavilla/OpenSearch-Dashboards-1/blob/main/src/cli_plugin/install/settings.js#L48

@kavilla do we any concern to remove the linux specific check to unblock windows distribution (also other OS)

@ruanyl
Copy link
Member

ruanyl commented Oct 19, 2022

I have the same issue on OSX, I was trying to trace the commit history and the original unit tests. But couldn't find a particular reason for why having the platform restriction on the plugin installation.

I can see that osd-opensearch has a restriction on OpenSearch snapshot installation for a particular platform(Linux) which makes sense if OpenSearch snapshot artifacts are only available for Linux for now.

My question: should the same restriction be applied to dashboard plugins? or do plugins actually have different binaries for different platforms?

@peterzhuamazon
Copy link
Member

@AMoo-Miki is working on fixing this as part of the windows support.

@AMoo-Miki
Copy link
Collaborator

This is fixed by #2601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants