-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Automate versioning, releasing and changelog generating with Changesets #2189
Comments
Hey @ruanyl thanks for starting the discussion. For dashboard plugins I see we have version increment done for more than one file (not only just the package.json files), example https://github.com/opensearch-project/security-dashboards-plugin/pull/1005/files, as part of the version increment process we should be able to handle them. |
Thanks @prudhvigodithi for the comment! Yes, I noticed the usage of 4 digit version, this could be challenged with Changeset as it expects SemVer, I'm not sure how easy to customize it via the plugin, need to double-check that. Unlike the release process which can be pretty much standardized, the version increment in other files can be different in different projects, a generic release automation tool probably should not handle this, I feel these can be done via project-specific scripts/templates as part of the release. |
Should be considered in opensearch-project/.github#148 |
Are there any concerns of introducing this set of tools into a non-JS toolset like in OpenSearch? Will developers have to do anything more? |
@ruanyl Thanks for all the suggestions about Changesets. Many of those ideas have been incorporated into the adopted proposal: opensearch-project/.github#156 |
Seeing people been discussing automated release in different contexts, I'd like to propose a possible solution.
Related issues #591 #1741 #1801
What's Changesets?
More details about Changesets can be found here: link to Changesets
Why Changesets?
package.json
for packages, no manual work needed, version get bump based on SemVerchangelogs
generating. By following Changesets workflow, all PRs need to be properly "documented" which ensures all changes are recorded in the changelogs when making a new release.I noticed people are also discussing 4 digit version in dashboard plugin projects while Changesets works with SemVer, but still, I'd love to raise the topic for discussion 😃 (I might miss some key points as I lack a full picture of the project)
The text was updated successfully, but these errors were encountered: