Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Visualization] [research] store a unique id for column data #2549

Open
ananzh opened this issue Oct 11, 2022 · 0 comments
Open

[Table Visualization] [research] store a unique id for column data #2549

ananzh opened this issue Oct 11, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers help wanted Community development is encouraged research tableVis table visualization visualizations Issues and PRs related to visualizations

Comments

@ananzh
Copy link
Member

ananzh commented Oct 11, 2022

Currently, in the new Table Vis code, we have switch usage between col.id and col index frequently. For example

return sort && sort.colIndex !== null && sort.direction
      ? [{ id: dataGridColumns[sort.colIndex]?.id, direction: sort.direction }]

The reason is that when we add/remove a column, the id might change. Below is an example that I add another column day_of_week. Count id is changed.

Screen Shot 2022-10-10 at 19 32 13

Screen Shot 2022-10-10 at 19 32 59

It would be nice to understand and simply the code. I opened this as a research issue to see if we could:

  • store a unique id
  • use id instead of index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Community development is encouraged research tableVis table visualization visualizations Issues and PRs related to visualizations
Projects
No open projects
Status: Todo
Development

No branches or pull requests

1 participant