-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] opensearch-dashboards-data-source-audit.log do not have line separator on cygwin/msys/mingw #2764
Comments
After taking a look it is a non-issue, closing now. |
This is actually an issue that needs to be resolved by dashboards. |
Seems like fixed in this PR just not being pulled in the latest artifact. |
@kristenTian can we confirm? |
Yes, #2793 was merged in. |
@peterzhuamazon is there ways I can verify your end functions now as well? |
I already confirmed this change is working in function test repo bundle e2e test. |
Hi,
https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/3383848918/jobs/5620140524#step:9:35
This will not happen on powershell but will happen on any mingw related emulated shell on windows.
bash: line 1: D:tmpopensearch-dashboards-data-source-audit.log: command not found
OpenSearch-Dashboards/src/plugins/data_source/audit_config.ts
Line 39 in 890a4b6
The path separator is removed in the process resulted in the log not able to be accessed.
Thanks.
The text was updated successfully, but these errors were encountered: