Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Table vis allows fields that can cause the app to crash #2923

Closed
2 tasks
ashwin-pc opened this issue Nov 23, 2022 · 4 comments
Closed
2 tasks

[BUG] Table vis allows fields that can cause the app to crash #2923

ashwin-pc opened this issue Nov 23, 2022 · 4 comments
Assignees
Labels
bug Something isn't working tableVis table visualization v2.5.0 'Issues and PRs related to version v2.5.0' vis builder

Comments

@ashwin-pc
Copy link
Member

Describe the bug

When a count field is added to the split rowss dropbox and then clicked to edit the agg type, the whole app crashes

To Reproduce
Steps to reproduce the behavior:

  1. Go to VisBuilder
  2. Drag and Drop count to "Split Rows"
  3. Click on the "filters" field (The dropped field)
  4. See app crash

Expected behavior

  • This field should not be allowed in the split rows dropbox.
  • The app should gracefully error in such a scenario

OpenSearch Version
3.0

Dashboards Version
3.0

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@ashwin-pc ashwin-pc added bug Something isn't working vis builder tableVis table visualization labels Nov 23, 2022
@ashwin-pc
Copy link
Member Author

The root cause here can be fixed quite easily by adding !filters to the agg filter for the table vis type. The bigger challenge is to make sure that issues like this does not takedown the whole application.

@ashwin-pc ashwin-pc added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 15, 2022
@ashwin-pc ashwin-pc self-assigned this Dec 15, 2022
@joshuarrrr
Copy link
Member

@ashwin-pc Is this still in scope for 2.5.0?

@ashwin-pc
Copy link
Member Author

yep, I'll have the PR out by tomorrow

@joshuarrrr
Copy link
Member

@ashwin-pc Can we close now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tableVis table visualization v2.5.0 'Issues and PRs related to version v2.5.0' vis builder
Projects
None yet
Development

No branches or pull requests

2 participants