Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Finalize eligibility based on vis configuration #3268

Closed
ohltyler opened this issue Jan 12, 2023 · 2 comments
Closed

[Feature Anywhere] Finalize eligibility based on vis configuration #3268

ohltyler opened this issue Jan 12, 2023 · 2 comments
Assignees
Labels
feature-anywhere visualizations Issues and PRs related to visualizations

Comments

@ohltyler
Copy link
Member

ohltyler commented Jan 12, 2023

As part of the logic for rendering plugin resources & overlays on a visualization, we need to have a clean way for determining a particular vis config is eligible for the feature.

Eligibility checks will be needed when:

  • collecting VisLayers or not in the VisualizeEmbeddable render flow
  • displaying the extra options in the context menu (the plugin-specific options, the 'View Events' option) - this will be done via isCompatible() fns of the actions that are triggered via CONTEXT_MENU_TRIGGER.

This roughly will include:

  • must be of type 'line'
  • must have a "valid" config (one set of x axes, x axis field is of type date, reasonable metrics, etc.). this will be the bulk of the work needed
  • must not show in the 'edit' context. basically, when viewing the details, we don't want to show, or even attempt to show, any VisLayers here. the feature is just for showing in the context of the dashboard. later improvements to the feature may support something to show / configure in the edit view
@ohltyler
Copy link
Member Author

ohltyler commented Feb 9, 2023

The placeholder function for the logic that will need to be added is included in #3131.

@ohltyler
Copy link
Member Author

Resolved via #3687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-anywhere visualizations Issues and PRs related to visualizations
Projects
None yet
Development

No branches or pull requests

3 participants