Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KUI usage in timeline or deprecate #3384

Closed
Tracked by #1060
joshuarrrr opened this issue Feb 4, 2023 · 1 comment
Closed
Tracked by #1060

Remove KUI usage in timeline or deprecate #3384

joshuarrrr opened this issue Feb 4, 2023 · 1 comment
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository. timeline ui library Issue or PR related to the UI component library

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Feb 4, 2023 •
edited
Loading

The timeline plugin uses a number of .kui* namespaced classes. See https://github.com/search?q=repo%3Aopensearch-project%2FOpenSearch-Dashboards+kui+path%3A%2F%5Esrc%5C%2Fplugins%5C%2Ftimeline%2F&type=code

However, given that timeline was already marked for deprecation, we may skip this issue in favor of complete removal as per #3519. I'd argue it's also safe to just remove these classes, even if it impacts styling and layout.
@joshuarrrr joshuarrrr mentioned this issue Feb 4, 2023
Open
9 tasks
@joshuarrrr joshuarrrr added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. timeline ui library Issue or PR related to the UI component library and removed untriaged labels Feb 4, 2023
@joshuarrrr joshuarrrr mentioned this issue Feb 4, 2023
Closed
@joshuarrrr joshuarrrr changed the title Remove KUI usage in timeline Remove KUI usage in timeline or deprecate Apr 11, 2023
@joshuarrrr
Copy link
Member Author

resolved via #3971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository. timeline ui library Issue or PR related to the UI component library
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuarrrr