Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dev tool console autocomplete suggestion doesn't suggest index name #3515

Closed
zhongnansu opened this issue Mar 2, 2023 · 11 comments · Fixed by #3775
Closed

[BUG] Dev tool console autocomplete suggestion doesn't suggest index name #3515

zhongnansu opened this issue Mar 2, 2023 · 11 comments · Fixed by #3775
Assignees
Labels
bug Something isn't working console v2.7.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Mar 2, 2023

Describe the bug

Auto-complete/suggest in dev_tool console has some issues. It doesn't pop up with suggestions for index name, field names, and there's no error message. Note that the endpoint suggestion does work, for example when you type in _s, it pops out candidates such as _search. But any suggestion requires dynamically querying OpenSearch is not working, for example index names suggestion.

To Reproduce
Go to https://playground.opensearch.org/app/dev_tools#/console and try

Expected behavior
image

OpenSearch Version
2.6

Dashboards Version
2.6

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@zhongnansu zhongnansu added bug Something isn't working untriaged labels Mar 2, 2023
@AMoo-Miki
Copy link
Collaborator

I just tried in on playground using Firefox 110 on macOS and it worked. Which browser and OS combo did you use?

@AMoo-Miki AMoo-Miki added the needs more info Requires more information from poster label Mar 3, 2023
@zhongnansu
Copy link
Member Author

zhongnansu commented Mar 3, 2023

I just tried in on playground using Firefox 110 on macOS and it worked. Which browser and OS combo did you use?

@AMoo-Miki Mac OS + Chrome. I updated the issue description. It's not that all suggestions are failing. Only those require querying OpenSearch is not working.

@zhongnansu zhongnansu changed the title [BUG] Dev tool console autocomplete suggestion is not working [BUG] Dev tool console autocomplete suggestion doesn't suggest index name Mar 3, 2023
@zhongnansu zhongnansu removed the needs more info Requires more information from poster label Mar 4, 2023
@kavilla kavilla removed the untriaged label Mar 6, 2023
@kavilla
Copy link
Member

kavilla commented Mar 6, 2023

Removing untriaged since maintainer opened issue.

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Mar 8, 2023

With #3080, the signature for opensearch.send changed to require http: HttpSetup as its first argument but its usage below was not modified.

return opensearch.send('GET', settingKeyToPathMap[settingsKey], null);

As a result, retrieveAutoCompleteInfo -> retrieveSettings fails to get the settings for fields, indices, and templates. retrieveAutoCompleteInfo is used in other places as well so all of them are broken.

@zhongnansu
Copy link
Member Author

@joshuarrrr literally this is not related to multiple datasource, removing the tag

@zhongnansu zhongnansu removed the multiple datasource multiple datasource project label Mar 26, 2023
@joshuarrrr
Copy link
Member

@zhongnansu I included it because it's on the checklist for #3577. Are you saying it isn't part of the GA scope? If so, let's remove it from that checklist. Should we also remove the 2.7.0 label here?

@zhongnansu
Copy link
Member Author

zhongnansu commented Mar 31, 2023

@joshuarrrr Not part of GA, but it's good to have. Because t's a bug with current dev tool console, not related to any change I made. I am still trying to fix it for 2.7. Added to the meta issue for tracking purpose, but this should have lowest priority, comparing to other task in that list.

@zhongnansu
Copy link
Member Author

zhongnansu commented Apr 4, 2023

posted PR #3775 to address the issue @joshuarrrr @AMoo-Miki @zengyan-amazon

@jonkerw85
Copy link

I also encounter this issue after upgrading our test cluster from 2.3 to 2.5. And have had contact with AWS support about this issue. We run OS as a manage service on AWS.

I have to discuss this internally but this issue might block us from upgrading the other cluster's to 2.5. Our developers expect the auto suggestion to be working, otherwise they might think the indices might not exist.

@joshuarrrr
Copy link
Member

@jonkerw85 The linked PR has the fix, which is targeted for the 2.7.0 release.

@zhongnansu zhongnansu linked a pull request Apr 6, 2023 that will close this issue
8 tasks
@zhongnansu
Copy link
Member Author

fixed by #3775, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working console v2.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants