Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Convert all /lib/autocomplete/**/*.js files to typescript #3826

Open
Tracked by #3825
joshuarrrr opened this issue Apr 11, 2023 · 3 comments
Open
Tracked by #3825

[Console] Convert all /lib/autocomplete/**/*.js files to typescript #3826

joshuarrrr opened this issue Apr 11, 2023 · 3 comments
Assignees
@curq
Labels
console help wanted Community development is encouraged technical debt If not paid, jeapardizes long-term success and maintainability of the repository. typescript

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Apr 11, 2023 •
edited
Loading 

find ./src/plugins/console/public/lib/autocomplete/ -name "*.js"
./src/plugins/console/public/lib/autocomplete/url_params.js
./src/plugins/console/public/lib/autocomplete/engine.js
./src/plugins/console/public/lib/autocomplete/components/constant_component.js
./src/plugins/console/public/lib/autocomplete/components/type_autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/components/global_only_component.js
./src/plugins/console/public/lib/autocomplete/components/id_autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/components/simple_param_component.js
./src/plugins/console/public/lib/autocomplete/components/conditional_proxy.js
./src/plugins/console/public/lib/autocomplete/components/index.js
./src/plugins/console/public/lib/autocomplete/components/list_component.js
./src/plugins/console/public/lib/autocomplete/components/index_autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/components/shared_component.js
./src/plugins/console/public/lib/autocomplete/components/username_autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/components/accept_endpoint_component.js
./src/plugins/console/public/lib/autocomplete/components/object_component.js
./src/plugins/console/public/lib/autocomplete/components/url_pattern_matcher.js
./src/plugins/console/public/lib/autocomplete/components/field_autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/components/autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/components/template_autocomplete_component.js
./src/plugins/console/public/lib/autocomplete/body_completer.js
./src/plugins/console/public/lib/autocomplete/__jest__/url_params.test.js
./src/plugins/console/public/lib/autocomplete/__jest__/url_autocomplete.test.js
@joshuarrrr joshuarrrr mentioned this issue Apr 11, 2023
Open
3 tasks
@joshuarrrr joshuarrrr added console technical debt If not paid, jeapardizes long-term success and maintainability of the repository. typescript help wanted Community development is encouraged and removed untriaged labels Apr 11, 2023
@sayuree
Copy link
Contributor

sayuree commented Apr 15, 2023 •
edited
Loading

@joshuarrrr So we need to rewrite the files and corresponding test files to TypeScript, right?

@joshuarrrr
Copy link
Member Author

@sayuree Yes, that's correct. See these resources:

  1. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/TYPESCRIPT.md
  2. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/DEVELOPER_GUIDE.md#typescriptjavascript

@curq
Copy link
Collaborator

curq commented Apr 25, 2023

Can you assign it to me please?

This was referenced May 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curq curq

Labels
console help wanted Community development is encouraged technical debt If not paid, jeapardizes long-term success and maintainability of the repository. typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuarrrr @sayuree @curq