Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis colors] Replace heatmap color schemas with palettes generated with colorPalette and OUI color variables #4325

Closed
Tracked by #4318
joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Assignees
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 19, 2023

Several OpenSearch Dashboards visualizations (VisLib Gauge, VisLib Goal, VisLib Heatmap, Metric) use color schemas from getHeatmapColors().

see https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/charts/public/static/color_maps/color_maps.ts

and opensearch-project/oui#601 for visual examples and defaults.

Instead, we should use OUI's colorPalette service to generate similar palettes with OUI color variables as the source. We can also reduce the number of color stops to 20, and simplify much of the mapping.

@manasvinibs
Copy link
Member

This PR addressed updating the maps color palette source to OUI. There are still utility functions, which does interpolate color maps in the charts plugin but it will be addressed as part of this issue #2830.
Resolving this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX
Projects
Status: Done
Development

No branches or pull requests

2 participants