-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define and standardize axis properties across visualizations #4328
Comments
@ohltyler can you specify why we need this extra field? A little more context for this issue would help |
@opensearch-project/opensearch-ux has noticed the default stroke width of the axes for vega lite are lighter/thinner than that of vislib chart axes. They would like consistency. Perhaps even hardcoding something in the post-processing steps (vega parser, vega view) would make more sense, since this field isn't something currently configurable based on the existing chart configs. |
@ohltyler This is on the roadmap as part of the Visualization Unification initiative. I've added it as a subtask to #3368 I think the next step here is for @KrooshalUX to provide some general guidance on axis styling that we can then apply to all visualizations, and I've generalized the title accordingly. As for the source code, to the best of my knowledge, this is where visLib sets the default line width to OpenSearch-Dashboards/src/plugins/vis_type_vislib/public/vislib/lib/axis/axis_config.js Line 54 in 1728318
But many specific chart types or layouts set that config to As for vis_type_vega, axis styling should be supplied via a default config - https://vega.github.io/vega-lite/docs/axis.html#config At the moment, I'd need to do more digging to see where that is specified, although I do know we inject additional config values in the parser: OpenSearch-Dashboards/src/plugins/vis_type_vega/public/data_model/vega_parser.ts Line 678 in 1728318
|
Currently stroke width of axes is only supported at the vega level (ref). Ideally we can have this specified within the vega plugin via an extra field such that when it is post-processed in the vega parser or the vega view, we can update the compiled vega spec to include the user-configured value.
The text was updated successfully, but these errors were encountered: