Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Colors] Remove hard coded color values from visualization functional tests #4424

Open
manasvinibs opened this issue Jun 28, 2023 · 0 comments
Labels
next-theme technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@manasvinibs
Copy link
Member

We have functional tests for dashboard state and app, which uses legacy seed colors, hard coded RGB and hex values of colors to test the Dashboard visualization functionality. We need to refactor all such tests to use colors from OUI.
Few such examples below -

await PageObjects.visChart.selectNewLegendColorChoice('#F9D9F9');

if (style.indexOf('rgb(255, 255, 255)') > 0) {

expect(pieSliceStyle.indexOf('rgb(87, 193, 123)')).to.be.greaterThan(0);

const colorExists = await PageObjects.visChart.doesSelectedLegendColorExist('#57c17b');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-theme technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
Status: Todo
Development

No branches or pull requests

2 participants