Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Re2 Requires wrong NODE_MODULE_VERSION #4518

Closed
sdbruder opened this issue Jul 7, 2023 · 5 comments
Closed

[BUG] Re2 Requires wrong NODE_MODULE_VERSION #4518

sdbruder opened this issue Jul 7, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@sdbruder
Copy link

sdbruder commented Jul 7, 2023

Describe the bug

regular expressions using re2 module fail. re2 was built with NODE_MODULE_VERSION 83 while opensearch dashboards 2.8.0 was built with NODE_MODULE_VERSION 93.

To Reproduce
Steps to reproduce the behavior:

  1. On opensearch-dashboards 2.8.0 (from the published container), create a dashboard
  2. Add a timeline with a regular expression
  3. See error

Expected behavior
actual executable and correct regular expressions,

OpenSearch Version
Opensearch 2.8.0 from container opensearchproject/opensearch:2.8.0.

Dashboards Version
Opensearch Dashboards 2.8.0 from container opensearchproject/opensearch-dashboards:2.8.0

Host/Environment (please complete the following information):

  • Actual official containers, so server OS is Amazon Linux release 2 (Karoo).
  • Browser here does not matter, it's a server side issue (but reproduced with both Chrome and Firefox).

Additional context

The actual error message:

[timeline_vis] > Timeline request error: undefined Error: in cell #1: The module 
‘/usr/share/opensearch-dashboards/node_modules/re2/build/Release/re2.node’ 
was compiled against a different Node.js version using NODE_MODULE_VERSION 83. 
This version of Node.js requires NODE_MODULE_VERSION 93. Please try re-compiling 
or re-installing the module (for instance, using npm rebuild or npm install).
@sdbruder sdbruder added bug Something isn't working untriaged labels Jul 7, 2023
@AMoo-Miki
Copy link
Collaborator

re2 was to be removed from the 2.8.0 release but looking at #4208, it didn't make it to the release.

Based on the error message, Node.js v16 is used at runtime but Node.js v14 was used to build the dependencies which is odd. I will investigate this.

@AMoo-Miki AMoo-Miki self-assigned this Jul 10, 2023
@smortex
Copy link

smortex commented Jul 15, 2023

Sample timeline expression that reproduce the error:

.opensearch().label(regex="(.*)")

@AMoo-Miki
Copy link
Collaborator

@ananzh, am i right to say 2.9.0 was released without re2 and that this issue can be closed now?

@smortex
Copy link

smortex commented Sep 1, 2023

@ananzh, am i right to say 2.9.0 was released without re2 and that this issue can be closed now?

@AMoo-Miki I confirm it is fixed and can be closed, thanks.

@AMoo-Miki
Copy link
Collaborator

Thanks @smortex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants