-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Left side bar can not be expanded and collapsed #4780
Comments
Because there's no PR open, relabeling for 2.12. |
As Kevin mentioned in his comment here: #5260 (comment), lets use the resizable container component from OUI to implement this. This should happen in the data explorer plugin's layout between the canvas and the sidebar. This is similar to the VisBuilder's implementation of the same care has to be taken to memoize the child components since resizing constantly rerenders the children unless memoized. |
This function is missing for me too or anybody with small screen. |
@wbeckler This is labeled for 2.12, but do we need to actually get an assignee? |
@joshuarrrr @ashwin-pc I have a solution ready for this problem and would be happy to contribute. Could someone guide me on the next steps or whether you would like me to submit a pull request? |
@Ganesh0107 Thanks! yes any contributions here would be appreciated. The goal was to use OUI's resizeable containers to do this https://oui.opensearch.org/1.3/#/layout/resizable-container%23collapsible-resizable-panels. The change is needed in the Data Explorer component. You can raise a PR for the change and I can help you with any issues that you might face while implementing it :) Thanks for volunteering to help with this |
thanks @ananzh and @ashwin-pc for suggesting this project for me, I would love to work on it! @Ganesh0107 if you are still interested in tackling this lmk. would love to collaborate :) |
@CMDWillYang I have assigned this to you. |
@CMDWillYang @ananzh I am about to raise PR in Couple of hours |
@Ganesh0107 thanks for opening the PR. I will remove @CMDWillYang and will start reviewing the PR. |
Close it as resolved |
Previously, the legacy discover have the left side bar expanded by default, and it also provides option to collapse the side bar.
Discover 2.0 does not have the expanding and collapsing functionalities anymore.
The text was updated successfully, but these errors were encountered: