Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Discover - 'truncate:maxHeight' no longer working 2.10.0 #5227

Closed
stevesimpson418 opened this issue Oct 5, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent v2.12.0

Comments

@stevesimpson418
Copy link

Discover - Maximum table cell height setting no longer working

In OpenSearch Dashboards 2.10.0 the new UI is no longer respecting the truncate:maxHeight Advanced Setting.

To Reproduce
Steps to reproduce the behavior:

  1. Index a document with a long string / or long log line. EG
PUT my-test-index/_doc/1
{
  "long_field": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Morbi mattis, nisl vitae blandit congue, nisl est aliquet sem, vel porttitor libero purus eu lectus. Morbi consequat euismod tortor vel eleifend. Phasellus sit amet vehicula metus. Vestibulum blandit velit euismod, cursus elit nec, cursus nisl. Etiam vitae est orci. Morbi tincidunt vitae nunc sed cursus. Donec scelerisque risus lorem, placerat maximus purus eleifend in. Cras porta quam libero, quis tincidunt neque venenatis ut. Nam in augue urna. Aenean ornare condimentum leo, et bibendum leo bibendum eget. Nulla faucibus diam ut sem posuere, id fringilla erat pulvinar. Fusce a enim quis augue bibendum molestie. Ut vitae auctor purus. Suspendisse et euismod enim. Nullam at ultricies risus, sed dignissim leo. In sollicitudin, tellus tincidunt rhoncus sollicitudin, metus ligula condimentum lacus, id aliquam arcu urna eu nisl. Vestibulum id nulla id sem ultrices gravida. In id mauris ultrices, sollicitudin ex luctus, congue magna. Nullam nec mauris est leo."
}
  1. Create the Index Pattern, my-test-index
  2. Set truncate:maxHeight: 0 in Dashboards Management>Advanced Settings.
  3. Attempt to visualise the data in the Discover app, you will see that the cells are truncated, ignoring the truncate:maxHeight setting.

Expected behavior
As with previous versions I would expect the cells to be truncated to the correct height as specified in the truncate:maxHeight setting, particularly if truncation is set to 0 and turned off. This is essential when debugging longer log lines.

OpenSearch Version
2.10.0
Docker image: opensearchproject/opensearch:2.10.0
Dashboards Version
2.10.0
Docker image: opensearchproject/opensearch-dashboards:2.10.0

Plugins

Only plugins loaded when running the official docker images, nothing extra

Screenshots
Screenshot 2023-10-05 at 14 02 11
Screenshot 2023-10-05 at 14 02 30

Host/Environment (please complete the following information):

  • OS: MacOS Ventura 13.6 | Official Docker OpenSearch Images from Docker Hub
  • Browser and version: Google Chrome 117

Additional context

This would work with previous versions of OpenSearch Discover and is vital when needing to debug several loglines at once that may stretch beyond the default truncation

@stevesimpson418 stevesimpson418 added bug Something isn't working untriaged labels Oct 5, 2023
@ananzh ananzh added data explorer Issues related to the Data Explorer project discover for discover reinvent labels Oct 10, 2023
@ananzh ananzh added v2.12.0 and removed untriaged labels Oct 10, 2023
@ashwin-pc ashwin-pc added the good first issue Good for newcomers label Oct 13, 2023
@m-kratochvil
Copy link

I see exactly the same issue in 2.11.0. This is unfortunate, and a fix would be much appreciated, I depend on the full log message during troubleshooting issues..

@ashwin-pc
Copy link
Member

ashwin-pc commented Dec 9, 2023

Given how Data Tables work i dont think this should work the same way in future. That being said, since the requirement here is to prevent the automatic truncation of the cell data, something like that can be achieved if the datatable can support auto row sizing. This unfortunately will require an update to the OUI Data Table component that needs to support dynamic row sizing. Once we have that we can fix this issue.

CC: @shanilpa @dagneyb @ahopp

Ive opened an issue in OUI to track this: opensearch-project/oui#1172

In the meantime i think adding a control on top of the table that allows the user to select the number of lines they want to see should mitigate some of the pain here until we have the ideal fix.

@ananzh
Copy link
Member

ananzh commented Feb 7, 2024

For 2.12, we restored legacy table where truncate:maxHeight work to adjust row height. For datagrid discover, we added a row height controller. Here is details:

multiline-both-table.mov

@stevesimpson418 do you think we could close this bug?

@sean-codevasp
Copy link

@ananzh video looks good. i am using managed opensearch in aws. hope this gets release asap with managed service as well. when do u expect that enduser of aws could get this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent v2.12.0
Projects
None yet
Development

No branches or pull requests

6 participants