Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Discover datasource selector X should be removed #5229

Closed
seanneumann opened this issue Oct 5, 2023 · 0 comments · Fixed by #5238
Closed

[BUG] Discover datasource selector X should be removed #5229

seanneumann opened this issue Oct 5, 2023 · 0 comments · Fixed by #5238
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent

Comments

@seanneumann
Copy link
Contributor

Describe the bug

image

When selecting a datasource in the Discover experience, the X button does not clear out the input (by design). So we should remove the X as an option.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Discover
  2. Click on datasource selector
  3. Click the X
  4. Notice how it doesn't clear the field.

Expected behavior
Remove the X because we actually don't want it to be cleared out and the X implies that behavior.

Dashboards Version
2.10, 2.11 early build

@seanneumann seanneumann added bug Something isn't working untriaged discover for discover reinvent de-angular de-angularize work data explorer Issues related to the Data Explorer project and removed de-angular de-angularize work labels Oct 5, 2023
@ananzh ananzh removed the untriaged label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants