Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] noreferrer on doc links #567

Closed
kavilla opened this issue Jun 29, 2021 · 1 comment · Fixed by #1709
Closed

[Improvement] noreferrer on doc links #567

kavilla opened this issue Jun 29, 2021 · 1 comment · Fixed by #1709
Assignees
@manasvinibs
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community development is encouraged

Comments

@kavilla
Copy link
Member

kavilla commented Jun 29, 2021

Is your feature request related to a problem? Please describe.
Stemming from this PR: #565. Links inconsistently have noreferrer on the reference.

'Adding rel="noopener noreferrer" to links protects your site's users against having the site you've linked to potentially hijacking the browser'

Describe the solution you'd like
Apply noreferrer to most, if not all, links.

Describe alternatives you've considered
n/a

Additional context

Add any other context or screenshots about the feature request here.
@kavilla kavilla added the enhancement New feature or request label Jun 29, 2021
@tmarkley tmarkley added the v1.2.0 label Sep 1, 2021
@tmarkley tmarkley added this to the 1.2 Release milestone Sep 1, 2021
@tmarkley tmarkley added help wanted Community development is encouraged and removed v1.2.0 labels Oct 26, 2021
@tmarkley tmarkley removed this from the 1.2 Release milestone Oct 26, 2021
@tmarkley
Copy link
Contributor

Potential option: add a linting rule?

@tmarkley tmarkley added the good first issue Good for newcomers label Nov 23, 2021
@manasvinibs manasvinibs self-assigned this Jun 8, 2022
@manasvinibs manasvinibs mentioned this issue Jun 8, 2022
Merged
7 tasks
@kavilla kavilla linked a pull request Jun 13, 2022 that will close this issue
[Improvement] Adding noreferrer on doc links #1709
Merged
7 tasks
@kavilla kavilla closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manasvinibs manasvinibs

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community development is encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Improvement] Adding noreferrer on doc links manasvinibs/OpenSearch-Dashboards
3 participants
@tmarkley @kavilla @manasvinibs