Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] EOL package joi used in Opensearch-dashboards #5691

Open
aggarwalShivani opened this issue Jan 16, 2024 · 0 comments
Open

[BUG] EOL package joi used in Opensearch-dashboards #5691

aggarwalShivani opened this issue Jan 16, 2024 · 0 comments
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@aggarwalShivani
Copy link

Describe the bug

Opensearch dashboards depends on a node-module joi 14.3.1 (see here )
As per this link, versions of joi<=14.3.1 have reached EOL and it is recommended to be replaced by @hapi/joi.
However, after 14.3.1, the next version available for joi after 14.3.1 is 17.x (see here).
There is slight confusion though if the new name of the package is joi or @hapi/joi.

Expected behavior
Opensearch-dashboards to not bundle dependencies/libraries that have reached EOL and aren't supported anymore.

Dashboards Version
3.0.0 (main branch of the project)

Ask:
To solve this, it would need a major version hop upgrade of joi from 14.x to 17.x (joi or @hapi/joi) in dependencies in dashboards.
Q1: Is this version upgrade already planned?
Q2: Is it feasible to do this version upgrade now? Are there any risks associated, or any architectural level changes needed with usage of this package?

Request feedback on the issue and mitigation plan for EOL issue.

@aggarwalShivani aggarwalShivani added bug Something isn't working untriaged labels Jan 16, 2024
@AMoo-Miki AMoo-Miki self-assigned this Feb 19, 2024
@AMoo-Miki AMoo-Miki added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. and removed untriaged bug Something isn't working labels Feb 19, 2024
@AMoo-Miki AMoo-Miki removed their assignment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

2 participants