Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OE] Plugins should bootstrap with --single-version=loose #6307

Open
kavilla opened this issue Apr 2, 2024 · 1 comment
Open

[OE] Plugins should bootstrap with --single-version=loose #6307

kavilla opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
build Build related additions or modifications enhancement New feature or request good first issue Good for newcomers operational excellence

Comments

@kavilla
Copy link
Member

kavilla commented Apr 2, 2024

Is your feature request related to a problem? Please describe.

By default, plugins will bootstrap as strict. This will compare dependencies with a lazy string compare and fail the build completely. Even for semvers that are the same, it will still fail.

This blocks developers from implementing with other plugins easily and prevents the distribution from being built with the plugin causing issues to be caught last minute.

Describe the solution you'd like

#5675 adds the support to be less strict about the version.

Within OpenSearch Dashboards main we should default the single-version to be loose. As we can do that with breaking changes.

Within 2.x we should audit all the OpenSearch Dashboards plugins within this OpenSearch project and create an issue or update their script to pass this value.

Thus we can ensure successful builds within the build pipeline and rely on integration tests to verify the run time of the application.

Describe alternatives you've considered

n/a

Additional context

Related issue:
#5953

@kavilla kavilla added the enhancement New feature or request label Apr 2, 2024
@kavilla kavilla added build Build related additions or modifications operational excellence good first issue Good for newcomers and removed untriaged labels Apr 2, 2024
@kavilla
Copy link
Member Author

kavilla commented Apr 2, 2024

This PR would benefit from this: opensearch-project/opensearch-dashboards-functional-test#800

Plugins can use the version they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related additions or modifications enhancement New feature or request good first issue Good for newcomers operational excellence
Projects
None yet
Development

No branches or pull requests

2 participants