Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Refactor data source readonly view component #6393

Closed
Tracked by #5872
BionIT opened this issue Apr 10, 2024 · 2 comments
Closed
Tracked by #5872

[Multiple Datasource] Refactor data source readonly view component #6393

BionIT opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.14.0

Comments

@BionIT
Copy link
Collaborator

BionIT commented Apr 10, 2024

Is your feature request related to a problem? Please describe.
There are a few props we need to add for data source view component:

  • optional data source filter, same as other data source components
  • hide local cluster, same as other data source components
  • onSelectedDataSources, same as other data source components, although this component doesn't allow selection, it needs to have a callback to tell plugins about the validity of the data source passed in

There are a few edge cases we need to address for the component and make sure we have tests that cover the following:

  • When id is empty string while hide local cluster setting is true, this is invalid case, will show toasts saying the data source is not available
  • When invalid data source id is passed in, the component should show toast saying the data source is not available in regardless of the hide local cluster setting
  • When empty data source id is passed in and hide local cluster setting is set to false, the component should show local cluster on initial load
  • When valid data source id is passed in, the data source component should show the data source

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@BionIT BionIT added enhancement New feature or request v2.14.0 multiple datasource multiple datasource project labels Apr 10, 2024
@BionIT BionIT self-assigned this Apr 10, 2024
@zhyuanqi
Copy link
Collaborator

Will take a look and work on it.

@BionIT BionIT assigned zhyuanqi and unassigned BionIT and zhyuanqi Apr 10, 2024
@BionIT
Copy link
Collaborator Author

BionIT commented Apr 10, 2024

Thanks a lot @zhyuanqi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.14.0
Projects
None yet
Development

No branches or pull requests

2 participants