Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Restrict saved objects finding for non dashboard admin #7127

Closed
wanglam opened this issue Jun 28, 2024 · 1 comment
Closed

[Workspace] Restrict saved objects finding for non dashboard admin #7127

wanglam opened this issue Jun 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@wanglam
Copy link
Contributor

wanglam commented Jun 28, 2024

Is your feature request related to a problem? Please describe.

This is a feature request. Non dashboard admin user can only view saved objects in permitted workspaces after workspace enabled. The non workspace saved objects can't be listing when out of workspace.

Describe the solution you'd like

We are going to refactor saved objects finding method in the workspace client wrapper. There are mainly three cases in the finding method. We are going to overwrite the finding options according below logic.

  1. Without options.workspaces and options.ACLSearchParams, should use permitted workspaces or default ACLSearchParams.
  2. With options.workspaces, not permitted workspaces will be filtered out.
  3. With options.ACLSearchParams, principals will be replaced to requested user.

Describe alternatives you've considered

N/A

Additional context

#4944

@wanglam wanglam added the enhancement New feature or request label Jun 28, 2024
@wanglam wanglam changed the title [Workspace] Restrict access to data sources for non dashboard admin [Workspace] Restrict saved objects finding for non dashboard admin Jul 5, 2024
@wanglam
Copy link
Contributor Author

wanglam commented Jul 8, 2024

Close since #7125 has been merged.

@wanglam wanglam closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant