-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] UI doesn't show version of distribution #731
Comments
The help menu is linked to package.json version value [here]. So we will need to make a change but for the bundle we should be able to mimic what we did for the rc1 version where we modified the package.json and bundled it. |
Hey, if we make a change to the UI here, let's be sure to use the right terminology: the collection of OpenSearch, OpenSearch Dashboards, and some number of plugins that are tested and distributed together is a "distribution". |
@jcgraybill Edited to reflect the correct terminology. |
@kavilla was this addressed? |
Confirmed that this was addressed in a previous change. The reason this didn't show as @ahopp Follow-up: we may need to be specific about what version this represents. We may need to specify the version of Dashboards, OpenSearch, and plugins? Or remove this altogether. If versions diverge this will be very important. |
@tmarkley So if there is a 1.1.1 with only a change in a plugin, will the correct version show? |
It will just as long as Dashboards bumps the package version number. |
@ahopp let's take a look at this. I see an opportunity to be more explicit about the versions we report here. For example, this could be updated to show the Dashboards version and the OpenSearch version since they aren't always the same. |
I'm going through some old issues to try to take care of some low hanging fruit. @ahopp @seanneumann @kgcreative can we land on a path forward here? Should we show both the Dashboards version and the OpenSearch version? How should we label them in the help menu? |
Since we now support multiple data sources and are working on decoupling Dashboards to run independently, I think we should only show the Dashboards version. And in the Stack Management / Data Sources we should list the endpoint versions. https://playground.opensearch.org/app/management/opensearch-dashboards/dataSources @seraphjiang Thoughts? |
Agree only show dashboards version, not the distribution version of all product. btw, dashboards has status page to see all plugins versions https://playground.opensearch.org/status the information is retrieved from https://playground.opensearch.org/api/status
show engine version of data source is a great idea if feasible. It should be a runtime version instead of static, retrieve when connect to endpoint. that way if customer upgrade their domain to new version, it got reflect without update datasource. |
Would it make sense to add a cc: @KrooshalUX |
This also leads me to think we need |
close per #6178 |
Describe the bug
The help menu displays
v1.0.0
- this is the version of OpenSearch Dashboards. In the upcoming distribution 1.0.1 release, only patch versions of the plugins will change and Dashboards is slated to not change. So, after upgrade Dashboards will still show 1.0.0, which will be confusing.To Reproduce
Steps to reproduce the behavior:
Expected behaviour
This area should should the correct distribution and dashboards version.
OpenSearch Version
1.0.0
Dashboards Version
1.0.0
Plugins
All OpenSearch
Screenshots
The text was updated successfully, but these errors were encountered: