Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest version of Cypress as a dependency #754

Closed
ohltyler opened this issue Sep 1, 2021 · 3 comments
Closed

Add latest version of Cypress as a dependency #754

ohltyler opened this issue Sep 1, 2021 · 3 comments
Labels
dependencies Pull requests that update a dependency file technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@ohltyler
Copy link
Member

ohltyler commented Sep 1, 2021

Currently, Dashboards doesn't support Cypress as a test framework. Many Dashboards plugins, however (Anomaly Detection, Index Management, etc.) are using it, but are maintaining individual versions of it. Because of this, there are occasional integration issues with different plugins, where mismatched versions are found and can cause warning or compilation errors. Trying to test all of the plugins together can also lead to failures, where running different major versions of Cypress can introduce breaking changes that cause some tests to unexpectedly fail.

Preferably, core Dashboards maintains Cypress versioning, and the downstream plugins can consume such versions. This would help maintain consistency and reliability in testing everything together. Additionally, I believe Dashboards should migrate to, and actively use, Cypress, for more consistency between core and the plugins.

@tmarkley
Copy link
Contributor

tmarkley commented Sep 2, 2021

@ohltyler To confirm, do we just need to take a dependency on the Cypress repo? Is there a particular version we should start with?

@tmarkley tmarkley added dependencies Pull requests that update a dependency file needs more info Requires more information from poster labels Sep 2, 2021
@ohltyler
Copy link
Member Author

ohltyler commented Sep 2, 2021

@ohltyler To confirm, do we just need to take a dependency on the Cypress repo? Is there a particular version we should start with?

Yeah, I guess this could be split into multiple steps.

  1. Pull in Cypress as a dependency via yarn add cypress. Using the latest version available is probably fine.
  2. Reach out to Dashboards plugin owners that plugin-specific versions of Cypress can be removed and consumed from core. This may require a bit of work from plugin teams to fix any broken tests that could be caused by breaking changes introduced in the newer version (e.g., AD Dashboards is using Cypress 5.x, latest is Cypress 8.x)
  3. Actively use it as a test framework for core Dashboards itself (can be done at a later time)

Just my thoughts. Let me know what you think.

@tmarkley
Copy link
Contributor

That sounds good to me! I think number 3 will indeed come at a later time but I think we can tackle 1 and 2.

@tmarkley tmarkley removed the needs more info Requires more information from poster label Sep 17, 2021
@tmarkley tmarkley changed the title Support Cypress test framework Add latest version of Cypress as a dependency Sep 17, 2021
@tmarkley tmarkley added the technical debt If not paid, jeapardizes long-term success and maintainability of the repository. label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

2 participants