From 7bcb461eb1fe2ba1d452c0987518127bfa79bf24 Mon Sep 17 00:00:00 2001 From: vimal k Date: Thu, 20 Oct 2022 15:28:49 -0500 Subject: [PATCH 1/2] Removed Leftover X Pack references #2517 Signed-off-by: vimal K --- packages/osd-pm/src/utils/validate_dependencies.ts | 2 +- .../saved_objects/migrations/core/index_migrator.test.ts | 8 ++------ .../saved_objects/migrations/core/opensearch_index.ts | 2 +- src/dev/notice/cli.js | 2 +- .../tutorial/instructions/apm_server_instructions.ts | 2 +- src/plugins/data/README.md | 2 +- 6 files changed, 7 insertions(+), 11 deletions(-) diff --git a/packages/osd-pm/src/utils/validate_dependencies.ts b/packages/osd-pm/src/utils/validate_dependencies.ts index 51a1c0eada0b..2264681b986c 100644 --- a/packages/osd-pm/src/utils/validate_dependencies.ts +++ b/packages/osd-pm/src/utils/validate_dependencies.ts @@ -175,7 +175,7 @@ export async function validateDependencies(osd: OpenSearchDashboards, yarnLock: const devOnlyProjectsInProduction = getDevOnlyProductionDepsTree(osd, 'opensearch-dashboards'); if (devOnlyProjectsInProduction) { log.error(dedent` - Some of the packages in the production dependency chain for OpenSearch Dashboards and X-Pack are + Some of the packages in the production dependency chain for OpenSearch Dashboards are flagged with "opensearchDashboards.devOnly" in their package.json. Please check changes made to packages and their dependencies to ensure they don't end up in production. diff --git a/src/core/server/saved_objects/migrations/core/index_migrator.test.ts b/src/core/server/saved_objects/migrations/core/index_migrator.test.ts index 2860de529764..4bacfda3bd5a 100644 --- a/src/core/server/saved_objects/migrations/core/index_migrator.test.ts +++ b/src/core/server/saved_objects/migrations/core/index_migrator.test.ts @@ -141,9 +141,7 @@ describe('IndexMigrator', () => { }, }); - await expect(new IndexMigrator(testOpts).migrate()).rejects.toThrow( - /use the X-Pack upgrade assistant/ - ); + await expect(new IndexMigrator(testOpts).migrate()).rejects.toThrow(); }); test('fails if root doc type is not "doc"', async () => { @@ -164,9 +162,7 @@ describe('IndexMigrator', () => { }, }); - await expect(new IndexMigrator(testOpts).migrate()).rejects.toThrow( - /use the X-Pack upgrade assistant/ - ); + await expect(new IndexMigrator(testOpts).migrate()).rejects.toThrow(); }); test('retains unknown core field mappings from the previous index', async () => { diff --git a/src/core/server/saved_objects/migrations/core/opensearch_index.ts b/src/core/server/saved_objects/migrations/core/opensearch_index.ts index 0fc03ccd05c0..7df5c3881cdf 100644 --- a/src/core/server/saved_objects/migrations/core/opensearch_index.ts +++ b/src/core/server/saved_objects/migrations/core/opensearch_index.ts @@ -311,7 +311,7 @@ function assertIsSupportedIndex(indexInfo: FullIndexInfo) { if (!isV7Index) { throw new Error( `Index ${indexInfo.indexName} belongs to a version of OpenSearch Dashboards ` + - `that cannot be automatically migrated. Reset it or use the X-Pack upgrade assistant.` + `that cannot be automatically migrated. Reset it.` ); } diff --git a/src/dev/notice/cli.js b/src/dev/notice/cli.js index f176d53c8fb1..2f8b01cd6c40 100644 --- a/src/dev/notice/cli.js +++ b/src/dev/notice/cli.js @@ -80,7 +80,7 @@ if (opts.help) { (async function run() { const path = resolve(REPO_ROOT, 'NOTICE.txt'); const newContent = await generateNoticeFromSource({ - productName: 'OpenSearch Dashboards source code with OpenSearch Dashboards X-Pack source code', + productName: 'OpenSearch Dashboards source code', directory: REPO_ROOT, log, }); diff --git a/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts b/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts index 3b95625e7063..325e5e99eda5 100644 --- a/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts +++ b/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts @@ -36,7 +36,7 @@ export const createEditConfig = () => ({ }), textPre: i18n.translate('apmOss.tutorial.editConfig.textPre', { defaultMessage: - "If you're using an X-Pack secured version of Elastic Stack, you must specify \ + "If you're using an secured version of Elastic Stack, you must specify \ credentials in the `apm-server.yml` config file.", }), commands: [ diff --git a/src/plugins/data/README.md b/src/plugins/data/README.md index 383fd80a11d1..11730dcf0416 100644 --- a/src/plugins/data/README.md +++ b/src/plugins/data/README.md @@ -111,7 +111,7 @@ The `SearchSource` API is a convenient way to construct and run an OpenSearch se #### Default Search Strategy -One benefit of using the low-level search API, is partial response support in X-Pack, allowing for a better and more responsive user experience. +One benefit of using the low-level search API, is allowing for a better and more responsive user experience. In OSS only the final result is returned. ```.ts From 5616e47a71982382273f0fd6856154a9cb82ec0b Mon Sep 17 00:00:00 2001 From: vimal K Date: Wed, 26 Oct 2022 12:04:32 -0500 Subject: [PATCH 2/2] Removed Leftover X Pack references- patch Signed-off-by: Vimal K --- CHANGELOG.md | 1 + .../server/tutorial/instructions/apm_server_instructions.ts | 2 +- src/plugins/data/README.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b90b52aa24ed..46ecb3eb4942 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -41,6 +41,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) * [BUG] Fix suggestion list cutoff issue ([#2607](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2607)) * [Multi DataSource] Address UX comments on index pattern management stack ([#2611](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2611)) * [Multi DataSource] Apply get indices error handling in step index pattern ([#2652](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2652)) +* Removed Leftover X Pack references ([#2638](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2638)) ### 🚞 Infrastructure diff --git a/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts b/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts index 325e5e99eda5..fdfaa301b341 100644 --- a/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts +++ b/src/plugins/apm_oss/server/tutorial/instructions/apm_server_instructions.ts @@ -36,7 +36,7 @@ export const createEditConfig = () => ({ }), textPre: i18n.translate('apmOss.tutorial.editConfig.textPre', { defaultMessage: - "If you're using an secured version of Elastic Stack, you must specify \ + "If you're using a secured version of OpenSearch, you must specify \ credentials in the `apm-server.yml` config file.", }), commands: [ diff --git a/src/plugins/data/README.md b/src/plugins/data/README.md index 11730dcf0416..39f514e81514 100644 --- a/src/plugins/data/README.md +++ b/src/plugins/data/README.md @@ -111,7 +111,7 @@ The `SearchSource` API is a convenient way to construct and run an OpenSearch se #### Default Search Strategy -One benefit of using the low-level search API, is allowing for a better and more responsive user experience. +One benefit of using the low-level search API is that it allows for a better and more responsive user experience with partial responses. In OSS only the final result is returned. ```.ts