From e9200d6ea6c487fcffb22c3755659a0c56eb546f Mon Sep 17 00:00:00 2001 From: Ashwin P Chandran Date: Wed, 2 Nov 2022 09:57:20 +0000 Subject: [PATCH 1/3] Enable VisBuilder cypress tests Signed-off-by: Ashwin P Chandran --- .github/workflows/cypress_workflow.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cypress_workflow.yml b/.github/workflows/cypress_workflow.yml index afe33c85ce17..30de01a9c163 100644 --- a/.github/workflows/cypress_workflow.yml +++ b/.github/workflows/cypress_workflow.yml @@ -12,6 +12,7 @@ env: START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch' OPENSEARCH_SNAPSHOT_CMD: 'node ../scripts/opensearch snapshot' SPEC: 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/*.js,' + CYPRESS_ENV: 'CYPRESS_VISBUILDER_ENABLED=true ' jobs: cypress-tests: @@ -75,7 +76,7 @@ jobs: working-directory: ${{ env.FTR_PATH }} start: ${{ env.OPENSEARCH_SNAPSHOT_CMD }}, ${{ env.START_CMD }} wait-on: 'http://localhost:9200, http://localhost:5601' - command: yarn cypress:run-without-security --browser chromium --spec ${{ env.SPEC }} + command: ${{ env.CYPRESS_ENV }} yarn cypress:run-without-security --browser chromium --spec ${{ env.SPEC }} # Screenshots are only captured on failure, will change this once we do visual regression tests - uses: actions/upload-artifact@v3 From 09814190c66fbfe461c768304b61fd6a7fbfafc5 Mon Sep 17 00:00:00 2001 From: Ashwin P Chandran Date: Thu, 3 Nov 2022 00:51:06 +0000 Subject: [PATCH 2/3] Adds changelog and fix env Signed-off-by: Ashwin P Chandran --- .github/workflows/cypress_workflow.yml | 2 +- CHANGELOG.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cypress_workflow.yml b/.github/workflows/cypress_workflow.yml index 30de01a9c163..c3458d6a94a6 100644 --- a/.github/workflows/cypress_workflow.yml +++ b/.github/workflows/cypress_workflow.yml @@ -12,7 +12,7 @@ env: START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch' OPENSEARCH_SNAPSHOT_CMD: 'node ../scripts/opensearch snapshot' SPEC: 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/*.js,' - CYPRESS_ENV: 'CYPRESS_VISBUILDER_ENABLED=true ' + CYPRESS_ENV: 'env CYPRESS_VISBUILDER_ENABLED=true ' jobs: cypress-tests: diff --git a/CHANGELOG.md b/CHANGELOG.md index 149531bbd7fc..ed7eb5e244ed 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id ([#2635](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2635)) - [Vis Builder] Rename wizard to visBuilder in class name, type name and function name ([#2639](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2639)) - [Vis Builder] Rename wizard on save modal and visualization table ([#2645](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2645)) +- [Vis Builder] Adds functional tests to CI ([#2728](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2728)) - Change save object type, wizard id and name to visBuilder #2673 ([#2673](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2673)) - Add extension point in saved object management to register namespaces and show filter ([#2656](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2656)) - [Multi DataSource] Update MD data source documentation link ([#2693](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2693)) From 7682146055df2ab87233cdc34b7a30c559594596 Mon Sep 17 00:00:00 2001 From: Ashwin P Chandran Date: Thu, 3 Nov 2022 01:54:18 +0000 Subject: [PATCH 3/3] Run all tests Signed-off-by: Ashwin P Chandran --- .github/workflows/cypress_workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cypress_workflow.yml b/.github/workflows/cypress_workflow.yml index c3458d6a94a6..41b9d46aa32f 100644 --- a/.github/workflows/cypress_workflow.yml +++ b/.github/workflows/cypress_workflow.yml @@ -11,7 +11,7 @@ env: FTR_PATH: 'ftr' START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch' OPENSEARCH_SNAPSHOT_CMD: 'node ../scripts/opensearch snapshot' - SPEC: 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/*.js,' + SPEC: 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/**/*.js,' CYPRESS_ENV: 'env CYPRESS_VISBUILDER_ENABLED=true ' jobs: