Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x][Windows] Make yarn pkg-version work across platforms (#2963) #2987

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[Backport 1.x][Windows] Make yarn pkg-version work across platforms (#2963) #2987

merged 1 commit into from
Dec 1, 2022

Conversation

AMoo-Miki
Copy link
Collaborator

Backport 3f576df from #2963

@AMoo-Miki
[Windows] Make yarn pkg-version work across platforms (opensearch-p…
29855ff 
…roject#2963)

* Makes `yarn pkg-version` work across platforms

cherry-pick from 3f576df

Signed-off-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki added backport 1.3 autocut Skip the changelog verification check on backports labels Dec 1, 2022
joshuarrrr
joshuarrrr approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - why did we not previously need this function in 1.x?

Approved, pending test completion, if needed.

@AMoo-Miki
Copy link
Collaborator Author

AMoo-Miki commented Dec 1, 2022 •
edited
Loading

Interesting - why did we not previously need this function in 1.x?

Approved, pending test completion, if needed.

I guess CI didn't use it. The new CI will use it.

@AMoo-Miki AMoo-Miki merged commit 5fde8d1 into opensearch-project:1.x Dec 1, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 1, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 1, 2022
@github-actions
[Windows] Make yarn pkg-version work across platforms (#2963) (#2987)
ab1f228 
* Makes `yarn pkg-version` work across platforms

cherry-pick from 3f576df

Signed-off-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 5fde8d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Dec 1, 2022
@opensearch-trigger-bot @github-actions
[Windows] Make yarn pkg-version work across platforms (#2963) (#2987)…
5fdddc8 
… (#2993)

* Makes `yarn pkg-version` work across platforms

cherry-pick from 3f576df

Signed-off-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 5fde8d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joshuarrrr joshuarrrr mentioned this pull request Dec 6, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports backport 1.3 v1.3.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMoo-Miki @joshuarrrr @kavilla