From 4af9ba87115cc83ebce70ba0f41c7e4d9688eeac Mon Sep 17 00:00:00 2001 From: Sagar Upadhyaya Date: Tue, 19 Mar 2024 09:39:34 -0700 Subject: [PATCH] Adding a ehcache issue reference for thread leak issue Signed-off-by: Sagar Upadhyaya --- .../opensearch/cache/store/disk/EhcacheThreadLeakFilter.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/plugins/cache-ehcache/src/test/java/org/opensearch/cache/store/disk/EhcacheThreadLeakFilter.java b/plugins/cache-ehcache/src/test/java/org/opensearch/cache/store/disk/EhcacheThreadLeakFilter.java index 5d4356bdbfcb8..5b1ac62fb7f31 100644 --- a/plugins/cache-ehcache/src/test/java/org/opensearch/cache/store/disk/EhcacheThreadLeakFilter.java +++ b/plugins/cache-ehcache/src/test/java/org/opensearch/cache/store/disk/EhcacheThreadLeakFilter.java @@ -11,10 +11,12 @@ import com.carrotsearch.randomizedtesting.ThreadFilter; /** - * In Ehcache(as of 3.8.0), while calling remove/invalidate() on entries causes to start a daemon thread in the + * In Ehcache(as of 3.10.8), while calling remove/invalidate() on entries causes to start a daemon thread in the * background to clean up the stale offheap memory associated with the disk cache. And this thread is not closed even * after we try to close the cache or cache manager. Considering that it requires a node restart to switch between * different cache plugins, this shouldn't be a problem for now. Will be following up with ehcache on this. + * + * See: https://github.com/ehcache/ehcache3/issues/3204 */ public class EhcacheThreadLeakFilter implements ThreadFilter {