Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlatObjectField will benefit from using IndexOrDocValuesQuery #11537

Open
harshavamsi opened this issue Dec 8, 2023 · 4 comments
Open

FlatObjectField will benefit from using IndexOrDocValuesQuery #11537

harshavamsi opened this issue Dec 8, 2023 · 4 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc

Comments

@harshavamsi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Similar to the efforts in #7057 and #11144, FlatObjectField has a bunch of MultiTermQueries that will benefit from being able to search documents when only doc_values is enabled and using IndexOrDocValuesQuery when it has both index and doc_values enabled.

Describe the solution you'd like
If only index is enabled, we return the existing query. If both index and doc_values are enabled we return a wrapped IndexOrDocValuesQuery. If only doc_values are enabled, we probably use SortedSetDocValuesField.newXyzQuery for range, fuzzy etc

Describe alternatives you've considered
Do nothing.

@harshavamsi harshavamsi added enhancement Enhancement or improvement to existing feature or request untriaged labels Dec 8, 2023
@harshavamsi
Copy link
Contributor Author

@mingshl I created this issue to track the work for FlatObjectField.

@getsaurabh02 getsaurabh02 moved this from Todo to Now (This Quarter) in Performance Roadmap Dec 8, 2023
@ankitkala ankitkala added Search Search query, autocomplete ...etc and removed Other labels Dec 17, 2023
@macohen
Copy link
Contributor

macohen commented Dec 20, 2023

@mingshl are you able to pick this up? If you're able, awesome, otherwise I think this should be unassigned or assigned to someone else.

@macohen macohen removed the untriaged label Dec 20, 2023
@mingshl
Copy link
Contributor

mingshl commented Dec 21, 2023

I have no problem picking this up. I saw a flat-object PR #11425 is up, and I would love to raise the new one after it's merged.

@msfroh
Copy link
Collaborator

msfroh commented Jan 4, 2024

Oh -- I think we can get this one "for free" if we address #11635

Basically, the two fields that make flat object work are both keyword fields, which have the IndexOrDocValueQuery optimizations. If flat object asks those fields to make their own queries, we'll get those optimizations.

@getsaurabh02 getsaurabh02 moved this from Now (This Quarter) to In Progress in Performance Roadmap Feb 19, 2024
@getsaurabh02 getsaurabh02 moved this from In Progress to Now (This Quarter) in Performance Roadmap Apr 8, 2024
@harshavamsi harshavamsi moved this from Now (This Quarter) to In Progress in Performance Roadmap Jun 17, 2024
@mch2 mch2 moved this from In Progress to In-Review in Performance Roadmap Aug 5, 2024
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc
Projects
Status: In-Review
Status: Later (6 months plus)
Development

No branches or pull requests

6 participants