Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOCUT] Gradle Check Flaky Test Report for MinDocCountIT #14313

Open
opensearch-ci-bot opened this issue Jun 13, 2024 · 4 comments
Open

[AUTOCUT] Gradle Check Flaky Test Report for MinDocCountIT #14313

opensearch-ci-bot opened this issue Jun 13, 2024 · 4 comments
Assignees
Labels
autocut flaky-test Random test failure that succeeds on second run Search:Aggregations Search Search query, autocomplete ...etc >test-failure Test failure from CI, local build, etc.

Comments

@opensearch-ci-bot
Copy link
Collaborator

opensearch-ci-bot commented Jun 13, 2024

Flaky Test Report for MinDocCountIT

Noticed the MinDocCountIT has some flaky, failing tests that failed during post-merge actions.

Details

Git Reference Merged Pull Request Build Details Test Name
42d6af6 14123 40485 org.opensearch.search.aggregations.bucket.MinDocCountIT.testDoubleCountDesc {p0={"search.concurrent_segment_search.enabled":"true"}}
c639e9a 14090 40463 org.opensearch.search.aggregations.bucket.MinDocCountIT.testHistogramKeyDesc {p0={"search.concurrent_segment_search.enabled":"true"}}

The other pull requests, besides those involved in post-merge actions, that contain failing tests with the MinDocCountIT class are:

For more details on the failed tests refer to OpenSearch Gradle Check Metrics dashboard.

@opensearch-ci-bot opensearch-ci-bot added >test-failure Test failure from CI, local build, etc. autocut untriaged labels Jun 13, 2024
@prudhvigodithi prudhvigodithi added the flaky-test Random test failure that succeeds on second run label Jun 14, 2024
@andrross andrross added the Search Search query, autocomplete ...etc label Jun 17, 2024
@jed326
Copy link
Collaborator

jed326 commented Jun 19, 2024

Looks like the MinDocCountIT.testDoubleCountDesc failure above is due to concurrent thread context modification bug for which fix has been merged: #14084

@jed326
Copy link
Collaborator

jed326 commented Jun 19, 2024

A quick scan through the other not post-merge related failures indicates that most of the other MinDocCountIT are due to the same issue fixed in #14084.

@jed326
Copy link
Collaborator

jed326 commented Jun 19, 2024

The failure for MinDocCountIT.testHistogramKeyDesc looks like it's finding an incorrect doc count for a given bucket key when minDocCount is used.

It's possible that this is due to concurrent search and minDocCount not being satisfied on one of the shards but it's also possible that it's due to one of the histogram rewrite changes. Unfortunately was not able to reproduce locally with the test seed.

@jed326
Copy link
Collaborator

jed326 commented Jun 19, 2024

My hunch was that this could be similar to the issue in #9085 for terms aggregations, however based on

if (reduced.getDocCount() >= minDocCount || reduceContext.isFinalReduce() == false) {
reducedBuckets.add(reduced);
}
it looks like minDocCount is only applied during the coordinator reduce which makes it unlikely that the this is due to concurrent search as the shard search requests should be identical in both cases.

Will defer to @bowenlan-amzn for any insights related to the recent histogram optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut flaky-test Random test failure that succeeds on second run Search:Aggregations Search Search query, autocomplete ...etc >test-failure Test failure from CI, local build, etc.
Projects
Status: Later (6 months plus)
Development

No branches or pull requests

6 participants