Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Create separate refresh listener to publish data about local segments being refreshed in remote segment tracker #8717

Closed
ashking94 opened this issue Jul 17, 2023 · 0 comments · Fixed by #8758
Closed

[Remote Store] Create separate refresh listener to publish data about local segments being refreshed in remote segment tracker #8717

ashking94 opened this issue Jul 17, 2023 · 0 comments · Fixed by #8758
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage Issues and PRs relating to data and metadata storage v2.10.0

Comments

@ashking94
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, on refresh, the afterRefresh of RefreshListener is invoked. There are certain cases where the method invocation can be delayed due to retry being happening. We should decouple the part of updating local segments information in segment tracker and the part of uploading segments.

Describe the solution you'd like
As described above.

Describe alternatives you've considered
It is being handled in #8683, but not ideal.

Additional context
Add any other context or screenshots about the feature request here.
@ashking94 ashking94 added enhancement Enhancement or improvement to existing feature or request untriaged Storage:Durability Issues and PRs related to the durability framework v2.1.0 Issues and PRs related to version 2.1.0 and removed untriaged labels Jul 17, 2023
@ashking94 ashking94 mentioned this issue Jul 18, 2023
Merged
6 tasks
@sachinpkale sachinpkale added v2.10.0 and removed v2.1.0 Issues and PRs related to version 2.1.0 labels Jul 18, 2023
@ashking94 ashking94 mentioned this issue Jul 18, 2023
Merged
6 tasks
@Bukhtawar Bukhtawar added the Storage Issues and PRs relating to data and metadata storage label Jul 27, 2023
@sachinpkale sachinpkale mentioned this issue Sep 6, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage Issues and PRs relating to data and metadata storage v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix local segments stats update in RemoteStoreRefreshListener ashking94/OpenSearch
3 participants
@sachinpkale @ashking94 @Bukhtawar