Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce index.query.max_nested_depth. backport 2.x #12286

Merged

Conversation

mkhludnev
Copy link
Contributor

@mkhludnev mkhludnev commented Feb 11, 2024

backporting #11670

@mkhludnev
Copy link
Contributor Author

fyi @reta

Copy link
Contributor

github-actions bot commented Feb 11, 2024

Compatibility status:

Checks if related components are compatible with change 9a224ab

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❕ Gradle check result for 24c4c44: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testScrollCreatedOnReplica
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d869ddd) 71.18% compared to head (9a224ab) 71.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12286      +/-   ##
============================================
+ Coverage     71.18%   71.28%   +0.09%     
- Complexity    59956    60006      +50     
============================================
  Files          4944     4944              
  Lines        282184   282197      +13     
  Branches      41334    41335       +1     
============================================
+ Hits         200860   201151     +291     
+ Misses        64282    64045     -237     
+ Partials      17042    17001      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 1a0049c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Feb 11, 2024

❌ Gradle check result for 1a0049c: FAILURE

Seems like the test needs adjustments as well

@reta
Copy link
Collaborator

reta commented Feb 12, 2024

@mkhludnev sorry DCO check is failing now :(

Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
@mkhludnev mkhludnev force-pushed the backport/backport-11670-to-2.x branch from 05296d9 to 9a224ab Compare February 12, 2024 16:41
Copy link
Contributor

❌ Gradle check result for 05296d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 9a224ab: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testScrollCreatedOnReplica
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@reta reta merged commit dfa41ea into opensearch-project:2.x Feb 12, 2024
31 checks passed
@reta reta added the v2.13.0 Issues and PRs related to version 2.13.0 label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.13.0 Issues and PRs related to version 2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants