Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding support for handling multiple transport protocols (#12967) #13125

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

VachaShah
Copy link
Collaborator

@VachaShah VachaShah commented Apr 8, 2024

Description

Backport #12967 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#12967)

* Adding support for more than one protocol for transport

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding CHANGELOG entry

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Addressing comments

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Removing determineTransportProtocol

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Determine transport protocol only on first byte reference

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Making InboundBytesHandler closeable

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Fixing close() for InboundPipeline

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding DeprecatedAPI annotation to japicmp task

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Fixing for detect breaking changes workflow

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Fixing recursion

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Compatibility status:

Checks if related components are compatible with change 99c23d8

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Apr 8, 2024

❌ Gradle check result for 5580bbf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Copy link
Contributor

github-actions bot commented Apr 8, 2024

❌ Gradle check result for 99c23d8: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2024

❕ Gradle check result for 99c23d8: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 87.84195% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 71.13%. Comparing base (0dd892c) to head (99c23d8).
Report is 119 commits behind head on 2.x.

Files Patch % Lines
...org/opensearch/transport/NativeMessageHandler.java 89.32% 11 Missing and 8 partials ⚠️
...port/nativeprotocol/NativeInboundBytesHandler.java 88.73% 0 Missing and 8 partials ⚠️
...java/org/opensearch/transport/InboundPipeline.java 66.66% 1 Missing and 3 partials ⚠️
...transport/nativeprotocol/NativeInboundMessage.java 90.90% 2 Missing and 2 partials ⚠️
.../java/org/opensearch/transport/InboundHandler.java 66.66% 1 Missing and 1 partial ⚠️
...in/java/org/opensearch/transport/TcpTransport.java 0.00% 2 Missing ⚠️
...java/org/opensearch/transport/TransportLogger.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13125      +/-   ##
============================================
- Coverage     71.28%   71.13%   -0.16%     
- Complexity    60145    60502     +357     
============================================
  Files          4957     5000      +43     
  Lines        282799   285004    +2205     
  Branches      41409    41644     +235     
============================================
+ Hits         201591   202732    +1141     
- Misses        64189    65147     +958     
- Partials      17019    17125     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VachaShah
Copy link
Collaborator Author

@reta Can you please approve this again? Somehow the minimum approval count check is not recognizing the approval. Thank you!!

@reta reta self-requested a review April 8, 2024 23:08
@reta reta merged commit 1dde447 into opensearch-project:2.x Apr 9, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants