Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for ClusterMetadataManifest after 2.15 backport #14226

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Jun 12, 2024

Description

We need to update the version check from StreamInput and StreamOutput for ClusterMetadataManifest as the changes have been backported to 2.15.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

❕ Gradle check result for 6d61daa: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (b15cb0c) to head (6d61daa).
Report is 410 commits behind head on main.

Files Patch % Lines
...search/gateway/remote/ClusterMetadataManifest.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14226      +/-   ##
============================================
+ Coverage     71.42%   71.65%   +0.23%     
- Complexity    59978    62058    +2080     
============================================
  Files          4985     5117     +132     
  Lines        282275   291685    +9410     
  Branches      40946    42166    +1220     
============================================
+ Hits         201603   209020    +7417     
- Misses        63999    65414    +1415     
- Partials      16673    17251     +578     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit 23458a4 into opensearch-project:main Jun 12, 2024
59 of 61 checks passed
@shiv0408 shiv0408 deleted the update_version branch June 12, 2024 17:29
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch that referenced this pull request Jun 13, 2024
…earch-project#14226)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 23458a4)
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants