-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] add query group stats constructs #15473
Conversation
* add query group stats constructs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add packageinfo for stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add total cancellations Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more granular level rejections Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add toXContent test cases Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * move ResourceType enum to wlm Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * update the comment for query group stats Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit c0bcacb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15473 +/- ##
============================================
- Coverage 71.72% 71.65% -0.08%
+ Complexity 63647 63615 -32
============================================
Files 5214 5216 +2
Lines 297407 297515 +108
Branches 43290 43302 +12
============================================
- Hits 213312 213180 -132
- Misses 66303 66515 +212
- Partials 17792 17820 +28 ☔ View full report in Codecov by Sentry. |
@jainankitk why we are merging pull request with breaking checks? |
@reta Ah, my bad! Missed the breaking check. Any reason the check is not required? |
I think we have difficulties configuring different checks for different branches, it is present in 2.x only but not 3.x |
Got it! Let us see how we can improve this as part of #15484 |
@reta How does the backward compatibility plugin works ? Because as per my understanding, if a node in source version cluster is moving an object to a node in target OS version then all it is doing is sending a binary representation of a string which the target node already has source code to decode and initialise the new object (just under different package). I ran the gradle task locally and following is erroneous abstract |
I think this is java serialisation issue not the OS level serialisation. Now since the enum has moved from one package to another the java serialisation will break but is that even necessary in this case @reta @jainankitk |
* Fixing backward incompatibility check Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing spotless violations Signed-off-by: Ankit Jain <akjain@amazon.com> * Adding missing javadocs Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com>
Backport c0bcacb from #15343.