Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] add query group stats constructs #15473

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c0bcacb from #15343.

* add query group stats constructs

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add changelog entry

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add packageinfo for stats

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add total cancellations

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add more granular level rejections

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add toXContent test cases

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* move ResourceType enum to wlm

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* update the comment for query group stats

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

---------

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
(cherry picked from commit c0bcacb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

✅ Gradle check result for 7e8212d: SUCCESS

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (635d2e9) to head (7e8212d).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...java/org/opensearch/wlm/stats/QueryGroupStats.java 87.20% 4 Missing and 7 partials ⚠️
...java/org/opensearch/wlm/stats/QueryGroupState.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15473      +/-   ##
============================================
- Coverage     71.72%   71.65%   -0.08%     
+ Complexity    63647    63615      -32     
============================================
  Files          5214     5216       +2     
  Lines        297407   297515     +108     
  Branches      43290    43302      +12     
============================================
- Hits         213312   213180     -132     
- Misses        66303    66515     +212     
- Partials      17792    17820      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit c63ad5a into 2.x Aug 28, 2024
57 of 58 checks passed
@jainankitk jainankitk deleted the backport/backport-15343-to-2.x branch August 28, 2024 17:50
@reta
Copy link
Collaborator

reta commented Aug 28, 2024

@jainankitk why we are merging pull request with breaking checks?

reta added a commit that referenced this pull request Aug 28, 2024
reta added a commit that referenced this pull request Aug 28, 2024
This reverts commit c63ad5a.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@jainankitk
Copy link
Collaborator

@jainankitk why we are merging pull request with breaking checks?

@reta Ah, my bad! Missed the breaking check. Any reason the check is not required?

@reta
Copy link
Collaborator

reta commented Aug 28, 2024

@jainankitk why we are merging pull request with breaking checks?

@reta Ah, my bad! Missed the breaking check. Any reason the check is not required?

I think we have difficulties configuring different checks for different branches, it is present in 2.x only but not 3.x

@jainankitk
Copy link
Collaborator

@jainankitk why we are merging pull request with breaking checks?

@reta Ah, my bad! Missed the breaking check. Any reason the check is not required?

I think we have difficulties configuring different checks for different branches, it is present in 2.x only but not 3.x

Got it! Let us see how we can improve this as part of #15484

@kaushalmahi12
Copy link
Contributor

kaushalmahi12 commented Aug 28, 2024

@reta How does the backward compatibility plugin works ? Because as per my understanding, if a node in source version cluster is moving an object to a node in target OS version then all it is doing is sending a binary representation of a string which the target node already has source code to decode and initialise the new object (just under different package).

I ran the gradle task locally and following is erroneous abstract
Screenshot 2024-08-28 at 1 28 10 PM

@kaushalmahi12
Copy link
Contributor

I think this is java serialisation issue not the OS level serialisation. Now since the enum has moved from one package to another the java serialisation will break but is that even necessary in this case @reta @jainankitk
?

reta pushed a commit that referenced this pull request Aug 29, 2024
* Fixing backward incompatibility check

Signed-off-by: Ankit Jain <akjain@amazon.com>

* Fixing spotless violations

Signed-off-by: Ankit Jain <akjain@amazon.com>

* Adding missing javadocs

Signed-off-by: Ankit Jain <akjain@amazon.com>

---------

Signed-off-by: Ankit Jain <akjain@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants