Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 #15695

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 4, 2024

Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2. Related #15692.

I would revert here but this is not a clean revert with multiple changes since it was introduced, so muting for now.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 402f941: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 402f941: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 402f941: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 402f941: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for f69b4de: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (729e40d) to head (f69b4de).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15695      +/-   ##
============================================
+ Coverage     71.95%   71.97%   +0.01%     
- Complexity    64192    64218      +26     
============================================
  Files          5270     5270              
  Lines        300052   300052              
  Branches      43368    43368              
============================================
+ Hits         215917   215975      +58     
+ Misses        66442    66342     -100     
- Partials      17693    17735      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 261b17a into opensearch-project:main Sep 5, 2024
33 of 34 checks passed
@sachinpkale sachinpkale added backport 2.x Backport to 2.x branch backport 2.17 labels Sep 5, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15695-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 261b17a4fb9978fc2a9ef82958efe5d7ff63ffa6
# Push it to GitHub
git push --set-upstream origin backport/backport-15695-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15695-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15695-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 261b17a4fb9978fc2a9ef82958efe5d7ff63ffa6
# Push it to GitHub
git push --set-upstream origin backport/backport-15695-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15695-to-2.17.

@sachinpkale sachinpkale added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Sep 6, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 261b17a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
sachinpkale added a commit that referenced this pull request Sep 6, 2024
* Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 (#15695)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Mute flaky test RemoteFsTimestampAwareTranslogTests.testSimpleOperationsUpload (#15732)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

* Mute failing snapshot status tests (#15652)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>

* Restore snapshot changes for shallow snapshot V2 (#15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>

* version change to V_2.17.0 for node min version check (#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants