-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Validate attributes of routing nodes for Routing Weights API #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-project#5607) * Changes following things in Routing Weights API and Decommission Action - a. Consider only routing node's attribute for validation instead of all nodes b. Ensure no more than 50% node has weight zero c. Removal of decommission action's direct dependence on force zone awareness Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
January 4, 2023 05:36
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #5691 +/- ##
============================================
- Coverage 70.69% 70.68% -0.02%
- Complexity 58651 58721 +70
============================================
Files 4740 4740
Lines 280526 280542 +16
Branches 40883 40889 +6
============================================
- Hits 198312 198290 -22
- Misses 65755 65812 +57
+ Partials 16459 16440 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bukhtawar
approved these changes
Jan 4, 2023
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
…ts API (#5691) * Validate attributes of routing nodes for Routing Weights API (#5607) * Changes following things in Routing Weights API and Decommission Action - a. Consider only routing node's attribute for validation instead of all nodes b. Ensure no more than 50% node has weight zero c. Removal of decommission action's direct dependence on force zone awareness Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #5607
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.