Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HOST_DENY_LIST usage and migrate it to notification plugin #134

Closed
dbbaughe opened this issue Jul 29, 2021 · 1 comment
Closed

Remove HOST_DENY_LIST usage and migrate it to notification plugin #134

dbbaughe opened this issue Jul 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@dbbaughe
Copy link

opensearch-project/notifications#247

@dbbaughe dbbaughe added the enhancement New feature or request label Jul 29, 2021
@qreshi
Copy link
Contributor

qreshi commented Apr 27, 2022

Notifications has the host deny list setting opensearch.notifications.core.http.host_deny_list (which uses the Alerting setting plugins.destination.host.deny_list and subsequently the legacy setting opendistro.destination.host.deny_list as fallbacks). If none of the mentioned settings are already set, the default is an empty list.

These changes were made in opensearch-project/notifications#424.

The Alerting versions of the settings are now deprecated and the plan is to remove them in 3.0. We're keeping them in 2.x so they can act as fallback settings to ensure smooth transitions for upgrading users since the Alerting setting was the only "host deny list" option for Destination configs up until now.

@qreshi qreshi closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants