Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Names don't adhere to plugin naming convention #741

Closed
mnkugler opened this issue Nov 30, 2022 · 2 comments
Closed

[BUG] Names don't adhere to plugin naming convention #741

mnkugler opened this issue Nov 30, 2022 · 2 comments
Labels
bug Something isn't working untriaged

Comments

@mnkugler
Copy link

What is the bug?
As per https://github.com/opensearch-project/opensearch-plugins/blob/main/CONVENTIONS.md#opensearch-plugins, the folder name needs to adhere to the naming convention

What is the expected behavior?
Folder needs to be created and Include full plugin name in kebab case, e.g., plugins/opensearch-anomaly-detection

Do you have any additional context?
Referred to here:
opensearch-project/opensearch-plugins#174

@mnkugler mnkugler added bug Something isn't working untriaged labels Nov 30, 2022
@amitgalitz
Copy link
Member

HI @mnkugler I'm a little confused what this change is exactly referring to. We don't have a plugins folder in our repository that would allow us to adhere to plugins/opensearch-anomaly-detection. Our current code is src which I assumed to be the standard for all plugins.

@mnkugler
Copy link
Author

mnkugler commented Dec 1, 2022

Hi @amitgalitz -- apologies. I realized that the naming convention I was referring to is outdated with respect to folders. We are removing the folders naming requirements since we are moving to one plugin per repo, as per opensearch-project/opensearch-build#2188 and I'm working on a pull request to fix the wording. We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

2 participants