From cdcf6a348d1f9e8ed235df65ca6785f6f9a425ba Mon Sep 17 00:00:00 2001 From: Aniruddh Srivastava Date: Sat, 11 Nov 2023 03:54:24 -0500 Subject: [PATCH 1/2] Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava --- .cypress/fixtures/test_slack_channel.json | 2 +- .cypress/integration/channels.spec.js | 2 +- test/mocks/mockData.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.cypress/fixtures/test_slack_channel.json b/.cypress/fixtures/test_slack_channel.json index 7643b2b0..e24a9446 100644 --- a/.cypress/fixtures/test_slack_channel.json +++ b/.cypress/fixtures/test_slack_channel.json @@ -5,7 +5,7 @@ "config_type": "slack", "is_enabled": true, "slack": { - "url": "https://sample-slack-webhook" + "url": "https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2" } } } \ No newline at end of file diff --git a/.cypress/integration/channels.spec.js b/.cypress/integration/channels.spec.js index d6c4804f..7d82fa7b 100644 --- a/.cypress/integration/channels.spec.js +++ b/.cypress/integration/channels.spec.js @@ -35,7 +35,7 @@ describe('Test create channels', () => { cy.get('[placeholder="Enter channel name"]').type('Test slack channel'); cy.get('[data-test-subj="create-channel-slack-webhook-input"]').type( - 'https://sample-slack-webhook' + 'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2' ); cy.wait(delay); cy.get('[data-test-subj="create-channel-send-test-message-button"]').click({ diff --git a/test/mocks/mockData.ts b/test/mocks/mockData.ts index ef20f091..786e8096 100644 --- a/test/mocks/mockData.ts +++ b/test/mocks/mockData.ts @@ -29,7 +29,7 @@ const mockSlack: ChannelItemType = { config_type: 'slack', is_enabled: false, slack: { - url: 'https://chimehook', + url: 'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2', }, config_id: 'test-slack', created_time_ms: 1622670451891, From 117c980351b1ed6a0366d3e5c140def7e690d86c Mon Sep 17 00:00:00 2001 From: Aniruddh Date: Wed, 22 Nov 2023 20:49:11 -0500 Subject: [PATCH 2/2] Update snapshot of unit tests Ran `yar test:jest -u` Signed-off-by: Aniruddh --- .../__snapshots__/ChannelSettingsDetails.test.tsx.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/pages/Channels/__tests__/__snapshots__/ChannelSettingsDetails.test.tsx.snap b/public/pages/Channels/__tests__/__snapshots__/ChannelSettingsDetails.test.tsx.snap index af944db4..5c5f7e07 100644 --- a/public/pages/Channels/__tests__/__snapshots__/ChannelSettingsDetails.test.tsx.snap +++ b/public/pages/Channels/__tests__/__snapshots__/ChannelSettingsDetails.test.tsx.snap @@ -182,7 +182,7 @@ exports[` spec renders Slack channel 1`] = `
- https://chimehook + https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2