Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK update in workflows to version 21 #352

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

sumukhswamy
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.47%. Comparing base (a8ca3b6) to head (d19aecb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   59.13%   57.47%   -1.66%     
==========================================
  Files          39       40       +1     
  Lines        1867     1907      +40     
  Branches      332      345      +13     
==========================================
- Hits         1104     1096       -8     
- Misses        647      689      +42     
- Partials      116      122       +6     
Flag Coverage Δ
dashboards-query-workbench 57.47% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48
Copy link
Member

ps48 commented Jul 17, 2024

@sumukhswamy Does this need a backport?

@ps48 ps48 changed the title added versiom bump JDK update in workflows to version 21 Jul 17, 2024
@sumukhswamy
Copy link
Collaborator Author

no backport needed 21 not needed for 2.x

@sumukhswamy sumukhswamy merged commit 7a8616e into opensearch-project:main Jul 17, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants