-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 2.0 alpha1 and gradle 7 #325
Bump to 2.0 alpha1 and gradle 7 #325
Conversation
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #325 +/- ##
============================================
+ Coverage 72.64% 74.23% +1.58%
- Complexity 373 383 +10
============================================
Files 94 94
Lines 3963 3966 +3
Branches 644 639 -5
============================================
+ Hits 2879 2944 +65
+ Misses 909 888 -21
+ Partials 175 134 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build seems to be failing, can you upgrade the following
enzyme-adapter-react-16
^1.15.5 => opensearch-dashboards
^1.15.2 => reports-dashboards
Signed-off-by: David Cui <davidcui@amazon.com>
reports-scheduler/build.gradle
Outdated
// 1.0.0 -> 1.0.0.0, and 1.0.0-SNAPSHOT -> 1.0.0.0-SNAPSHOT | ||
opensearch_build = opensearch_version.replaceAll(/(\.\d)([^\d]*)$/, '$1.0$2') | ||
opensearch_build = opensearch_version.replaceAll(/(\.\d(?!\.\d))/, '$1.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opensearch_build = opensearch_version.replaceAll(/([\d.]*.\d+(?!.\d))/, '$1.0')
Please replace this to handle multiple digits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was common-utils 2.0.0 alpha1 deprecated? backend build is failing immediately because it can't resolve the reference
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumping gradle 7, reporting to 2.0 and removed mapping types Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui davidcui@amazon.com
Description
CreateIndexRequest
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.