Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Lambda Sink flaky tests & logging #4723

Merged
merged 1 commit into from
Jul 11, 2024
Merged

AWS Lambda Sink flaky tests & logging #4723

merged 1 commit into from
Jul 11, 2024

Conversation

dlvenable
Copy link
Member

Description

This fixes a flaky test.

LambdaSinkServiceTest > lambda_sink_test_batch_enabled() FAILED
    org.mockito.exceptions.verification.WantedButNotInvoked at LambdaSinkServiceTest.java:316

#3481 (comment)

Two changes:

  • Use a max event count of 1 to verify that we call the Lambda API.
  • Adds SLF4J logging to this project. That is partially how I was able to find the cause.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
7570ebb 
…LF4J logging for these tests.

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable mentioned this pull request Jul 11, 2024
Merged
4 tasks
@dlvenable
Copy link
Member Author

Locally, I changed this test to be a @RepeatedTest(20). When running, I found that it typically failed 18 out of the 20 times! With the change introduced here, it passed in all 20 runs.

@dlvenable dlvenable merged commit 5420162 into opensearch-project:main Jul 11, 2024
45 of 47 checks passed
@dlvenable dlvenable mentioned this pull request Jul 12, 2024
Open
14 tasks
@dlvenable dlvenable deleted the lambda-sink-flaky branch July 12, 2024 14:18
kkondaka pushed a commit to kkondaka/kk-data-prepper-f2 that referenced this pull request Jul 23, 2024
@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
e0bfb72 
…LF4J logging for these tests. (opensearch-project#4723)

Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka pushed a commit to kkondaka/kk-data-prepper-f2 that referenced this pull request Jul 23, 2024
@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
e2c46a1 
…LF4J logging for these tests. (opensearch-project#4723)

Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka pushed a commit to kkondaka/kk-data-prepper-f2 that referenced this pull request Jul 30, 2024
@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
b62052b 
…LF4J logging for these tests. (opensearch-project#4723)

Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka pushed a commit to kkondaka/kk-data-prepper-f2 that referenced this pull request Aug 8, 2024
@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
88bb51d 
…LF4J logging for these tests. (opensearch-project#4723)

Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka pushed a commit to kkondaka/kk-data-prepper-f2 that referenced this pull request Aug 12, 2024
@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
1b047d9 
…LF4J logging for these tests. (opensearch-project#4723)

Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
kkondaka pushed a commit to kkondaka/kk-data-prepper-f2 that referenced this pull request Aug 14, 2024
@dlvenable
Updates to the AWS Lambda Sink tests to fix a flaky test. Also adds S…
c37595d 
…LF4J logging for these tests. (opensearch-project#4723)

Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graytaylor0 graytaylor0 graytaylor0 approved these changes

@srikanthjg srikanthjg srikanthjg approved these changes

@chenqi0805 chenqi0805 Awaiting requested review from chenqi0805 chenqi0805 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@dinujoh dinujoh Awaiting requested review from dinujoh dinujoh is a code owner

@kkondaka kkondaka Awaiting requested review from kkondaka kkondaka is a code owner

@KarstenSchnitter KarstenSchnitter Awaiting requested review from KarstenSchnitter KarstenSchnitter is a code owner

@oeyh oeyh Awaiting requested review from oeyh oeyh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlvenable @srikanthjg @graytaylor0