Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FlowFrameworkRestApiIT is flaky / fails on macOS #305

Closed
dbwiddis opened this issue Dec 20, 2023 · 0 comments · Fixed by #306
Closed

[BUG] FlowFrameworkRestApiIT is flaky / fails on macOS #305

dbwiddis opened this issue Dec 20, 2023 · 0 comments · Fixed by #306
Assignees
Labels
bug Something isn't working untriaged v2.12.0

Comments

@dbwiddis
Copy link
Member

What is the bug?

Encountered during local testing of #303 on 2.x but now seeing on macOS IT's for #298 .

Sample CI run: https://github.com/opensearch-project/flow-framework/actions/runs/7279871426/job/19837300702#step:4:46

org.opensearch.flowframework.rest.FlowFrameworkRestApiIT > testCreateAndProvisionRemoteModelWorkflow FAILED
    org.junit.ComparisonFailure: expected:<[COMPLETED]> but was:<[PROVISIONING]>
<snip>
        at org.opensearch.flowframework.rest.FlowFrameworkRestApiIT.testCreateAndProvisionRemoteModelWorkflow(FlowFrameworkRestApiIT.java:171)

Relevant line in the logs is a bit lower:

Suite: Test class org.opensearch.flowframework.rest.FlowFrameworkRestApiIT
  1> [2023-12-20T14:33:07,274][INFO ][o.o.f.r.FlowFrameworkRestApiIT] [testCreateAndProvisionLocalModelWorkflow] There are still tasks running after this test that might break subsequent tests [cluster:admin/opensearch/ml/register_model, indices:admin/create].

How can one reproduce the bug?

Run integ tests on macOS GitHub runners on current main branch. (It seems to pass locally.)

What is the expected behavior?

CI Tests pass.

What is your host/environment?

macOS github runners.

Do you have any additional context?

Of note, the problematic task is associated with a local model, which we haven't yet fully implemented. I commented out failing lines earlier here:

// TODO: This provisioning isn't completing, probably due to incorrect task vs. model ID in RetryableWorkflowStep
// May be fixed by https://github.com/opensearch-project/flow-framework/pull/298
// Wait until provisioning has completed successfully before attempting to retrieve created resources
// List<ResourceCreated> resourcesCreated = getResourcesCreated(workflowId, 100);
// TODO: This template should create 2 resources, registered_model_id and deployed model_id
// But RegisterLocalModelStep does not yet update state index so might be 1
// assertEquals(0, resourcesCreated.size());

It might be that entire test needs to be removed until we've fully implemented the Local Model steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged v2.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant