Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][opensearch-dashboards] Use global.dockerRegistry just like in the opensearch chart #528

Open
cpockrandt opened this issue Mar 19, 2024 · 2 comments
Open

[Enhancement][opensearch-dashboards] Use global.dockerRegistry just like in the opensearch chart #528

cpockrandt opened this issue Mar 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cpockrandt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I noticed that the opensearch and opensearch-dashboards chart use different approaches when it comes to the dockerRegistry. While I can set global.dockerRegistry in the opensearch chart, I need to overwrite image.repository in the opensearch-dashboards chart. Wouldn't it make sense to unify both charts, or is there a reason why the opensearch-dashboards chart doesn't use the global.dockerRegistry?
@cpockrandt cpockrandt added enhancement New feature or request untriaged Issues that have not yet been triaged labels Mar 19, 2024
@rishabh6788 rishabh6788 removed the untriaged Issues that have not yet been triaged label Apr 1, 2024
@rishabh6788
Copy link
Contributor

@prudhvigodithi Please take a look.

@prudhvigodithi
Copy link
Collaborator

[Triage]
Thanks @cpockrandt, similar to what we have here https://github.com/opensearch-project/helm-charts/blob/main/charts/opensearch/values.yaml#L27-L29, are you open to please contribute this?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Engineering Effectiveness Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpockrandt @rishabh6788 @prudhvigodithi