[FEATURE]Refactoring of code for better maintainability #1810
Labels
enhancement
Refactoring
Improve the design, structure, and implementation while preserving its functionality
After introducing binary vector format of which has its own code path in across multiple files, the needs of refactoring is required to enhance code maintainability.
Related PR. #1781
Few action items are as follow
KNNQuery
class. One for float/byte vectors and another for binary vector. We want to refactor it so that it won't have two vector variables inside single KNNQuery.VectorTransfer
class. The issue with this class is that the caller should callclose()
method at the end to make sure the transfer complete properly. We want to avoid such requirement.NestedFilteredIdsKNNByteIterator
,FilteredIdsKNNByteIterator
,NestedFilteredIdsKNNIterator
, andFilteredIdsKNNIterator
. We want to remove theByte
iterator and reduce code duplication.KNNVectorSimilarityFunction
to wrap lucene'sVectorSimilarityFunction
. We might want to see if there is other ways to avoid this thin wrapper.The text was updated successfully, but these errors were encountered: