-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ML-Commons Plugin build failure due to OpenSearch Core breaking changes #891
Comments
This is a bug in Gradle - gradle/gradle#24390 |
We need to bump
following fixing PRs opensearch-project/neural-search#169, opensearch-project/k-NN#899 |
After bumping
|
This is due to OS core breaking changes opensearch-project/OpenSearch#7309 |
Following this PR opensearch-project/k-NN#885 to fix this problem. |
./gradlew build failed in test step:
|
This is due to breaking changes in OS core: opensearch-project/OpenSearch#7301, the |
Tagging @nknize @reta @saratvemulapalli |
The migration from
|
Another breaking change is the string length limit from this PR By bumping jackson version, we will introduce the string length limitation FasterXML/jackson-core#1001 (comment) The model content saved as Base64 String in index. As model content string exceeds the string limit, our IT failed. @reta created an opensearch-project/OpenSearch#7549 to support tuning string length limit, before that ready, we have to disable our IT, also neural-search plugin has to disable their IT |
As we root causing this issue, we found
Trying to use this code to continue the RCA. Update: The PR #884 can reproduce this problem, but definitely not RC because main branch has not merged this. |
Could we have quick fix before RCA? There are 5 version bump PR pending on this #850 and SQL main branch bwc IT pending on this |
@b4sjoo can we ignore the failed IT/UT to unblock other teams first? |
@penghuo @ylwu-amzn the fix for Jackson 2.15 content limits went in to |
So we simply delete the problematic IT first? |
Refer to |
Problematic IT was ignored and build passed. |
Github CI workflow failed due to
|
Add a task configuration |
Jenkins CI workflow on OS 3.0 failed with message:
https://build.ci.opensearch.org/job/distribution-build-opensearch/7856/console We try to fix it with PR #901 |
Here is an issue board to track most of the breaking changes in OS core in 3.0, please keep an eye on it - opensearch-project/OpenSearch#5910 |
And also a place to provide feedback - opensearch-project/opensearch-devops#114 |
Which is due to major refactor in OS core 3.0:
opensearch-project/OpenSearch#7508
Here is a temporary fix method: |
Created a fix PR #901 I got following integ test error message after migration from
The line for
And UnitTests were passed. Any thoughts? |
The integ test error is due to docker image not update. Now integ tests were passed. Issue resolved. |
We did another fix in #962 due to ml-commons not building when publishing ml-client artifacts. |
After opensearch-build team migrate from jdk17 to jdk20, task
|
I think But when I try to build
Mainly the issue i think:
|
Yeah it seems there will be many breaking changes after migrating to jdk20, sigh... |
Update: We can reproduce the same error in our end with executing:
|
Do you folks need help with that? The lombok is real bummer for any recent JDK updates, Mockito 5.x has no issues with JDK-20 |
@reta Right now OS is building failing due to delombok issue, we created an issue in freefair. If you have any suggestion about the delombok issue that will be helpful. In addition, we are facing build error:
We are adding jacoco dependencies here. If you have any suggestion how to solve this issue, that will also be helpful. Thanks. |
@dhrubo-os anything left here you need help with folks? or we could close it :) |
@reta I think that's all the support we needed for now. Thanks a lot. I'm waiting for a successful build for OS build issue. After confirming this, I'll close the issue. |
Tested the build in my end and the build was successful. Closing the issue. Thanks. |
#1191 Provide a final solution to |
More refactoring from OS core - opensearch-project/OpenSearch#8157 |
What is the bug?
ML-Commons Plugin 3.0 build fails due to jackson update in OS core
How can one reproduce the bug?
The text was updated successfully, but these errors were encountered: