Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mapping types #150

Closed
dreamer-89 opened this issue Mar 2, 2022 · 1 comment · Fixed by #186
Closed

Remove mapping types #150

dreamer-89 opened this issue Mar 2, 2022 · 1 comment · Fixed by #186
Labels
breaking enhancement New feature or request v2.0.0

Comments

@dreamer-89
Copy link
Member

As part of v2.0 release, mapping types are getting removed from OpenSearch engine. Below are the changes in the opensearch-engine.

  • Removal of type from rest end-points
  • Removal of include_type_name parameter from API requests.

As part of this issue, please verify if type removal change on OpenSearch engine impacts this repository. If yes, then please remove the type references/usage from this repository

Related: OpenSearch-engine meta issue

@engechas
Copy link
Contributor

This change will affect OSB, we will need to prioritize a fix.

Areas of Change

"include_type_name": "true"



Potential other areas that will need to change (needs further investigation)

self.es_mock.bulk_index.assert_called_with(index="benchmark-metrics-2016-01", doc_type="_doc", items=[expected_doc])


opensearch.bulk.assert_called_with(doc_type="_doc",

METRICS_DOC_TYPE = "_doc"

TEST_EXECUTION_DOC_TYPE = "_doc"


"_doc": "no closing quotation mark!!,


The workloads may require changes as well. The "6" branch has instances of doc in the index mappings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request v2.0.0
Projects
None yet
2 participants