Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert component-based scripts lookup #2945

Closed
dblock opened this issue Nov 30, 2022 · 5 comments · Fixed by #3540
Closed

Revert component-based scripts lookup #2945

dblock opened this issue Nov 30, 2022 · 5 comments · Fixed by #3540
Labels
enhancement New Enhancement

Comments

@dblock
Copy link
Member

dblock commented Nov 30, 2022

Is your feature request related to a problem? Please describe

In #2934 we have added a way to include component build scripts. There are several problems with that.

  1. In Separate monorepos (e.g. OS and OSD plugins) to different repositories #2188 we agreed to split monorepos. The maps monorepo came in as another new kind of monorepo that should not be supported.
  2. There are no tests in the PR.
  3. The new feature of path lookup is not documented in
    it will look in the following locations, in order:

Describe the solution you'd like

  1. Add tests and documentation on top of allow find build script by repo component #2934.
  2. Split the maps monorepo, Separate monorepos (e.g. OS and OSD plugins) to different repositories #2188
  3. Revert allow find build script by repo component #2934

Describe alternatives you've considered

No response

Additional context

No response

@gaiksaya
Copy link
Member

[Triage] Hi @junqiu-lei Any plans on separating the repos?

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Dec 15, 2022
@junqiu-lei
Copy link
Member

Hi @gaiksaya , will take actions based on decision from opensearch-project/dashboards-maps#95

@bbarani
Copy link
Member

bbarani commented May 19, 2023

@junqiu-lei @gaiksaya Can you provide an update on this issue?

@gaiksaya
Copy link
Member

I believe this PR took care of adding tests and documentation: #2952
These are the components in build repo that still have scripts here: https://github.com/opensearch-project/opensearch-build/tree/main/scripts/components

@junqiu-lei
Copy link
Member

junqiu-lei commented May 22, 2023

I'll raise a PR for the revert of #2934 #2952, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants