Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Incremental Build] Build incremental components through build workflow #4210

Closed
Tracked by #3922
zelinh opened this issue Nov 13, 2023 · 2 comments
Closed
Tracked by #3922
Assignees
Labels
enhancement New Enhancement feature New feature

Comments

@zelinh
Copy link
Member

zelinh commented Nov 13, 2023

This is a sub-issue from #3922

Once we have a list of rebuilding plugins obtained from this issue, we should be able to run the build workflow with these components.

Acceptance Critieria:

  • The build workflow will run through only those designated components.
  • The build manifest will be updated with rebuilding artifacts and keep unchanged artifacts from previous build.
  • The build itself should run with no errors.

Implementation plan.
We would run our current build_workflow with these components until recording/generating the build_manifest.

Since we don’t want to erase other previously build components from the build manifest, we would take input of the build manifest with relative path builds/opensearch/manifest.yml. After reading through the previous manifest, we would be updating the manifest with whatever components that we just incremental build.

We have BuildManifestBuilder class in build_recorder.py. Normally it starts from scratch; if we only build few components, it would only record those built plugins.

However, we can add a functionality to the builder itself. When incremental argument is enable, it would firstly read through builds/opensearch/manifest.yml and append/update the currently building components to the manifest.

@zelinh zelinh self-assigned this Nov 13, 2023
@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Nov 13, 2023
@zelinh zelinh added enhancement New Enhancement feature New feature and removed untriaged Issues that have not yet been triaged labels Nov 13, 2023
@zelinh zelinh moved this from Backlog to In Progress in OpenSearch Engineering Effectiveness Nov 13, 2023
@gaiksaya
Copy link
Member

gaiksaya commented Jan 5, 2024

Hi @zelinh ,

Looks like associated PR is merged. Can we close this issue?
Thanks!

@zelinh
Copy link
Member Author

zelinh commented Jan 5, 2024

This issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement feature New feature
Projects
Development

No branches or pull requests

2 participants